android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java - Issue 976393002: [Android WebView] Implement OnReceivedHttpError callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Issue 976393002: [Android WebView] Implement OnReceivedHttpError callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/aw_network_delegate.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

index 6f15bae961d0a0ab118950756f8207df7482ff49..f997c818f6ae12e90258e6bf7df3ce6220cf974f 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

@@ -593,6 +593,17 @@ public class WebViewContentsClientAdapter extends AwContentsClient {

}

+ @Override

+ public void onReceivedHttpError(AwWebResourceRequest request, AwWebResourceResponse response) {

+ try {

+ TraceEvent.begin("WebViewContentsClientAdapter.onReceivedHttpError");

+ if (TRACE) Log.d(TAG, "onReceivedHttpError=" + request.url);

+ // TODO(mnaganov): Call mWebViewClient.onReceivedHttpError(mWebView, request, response);

+ } finally {

+ TraceEvent.end("WebViewContentsClientAdapter.onReceivedHttpError");

+ }

/**

* @see ContentViewClient#onReceivedTitle(String)