Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java

Issue 976393002: [Android WebView] Implement OnReceivedHttpError callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
index 6f15bae961d0a0ab118950756f8207df7482ff49..f997c818f6ae12e90258e6bf7df3ce6220cf974f 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
@@ -593,6 +593,17 @@ public class WebViewContentsClientAdapter extends AwContentsClient {
}
}
+ @Override
sgurun-gerrit only 2015/03/06 06:49:25 this code will need to go to the "new" glue layer.
mnaganov (inactive) 2015/03/06 12:58:25 I would argue that glue code functions should stil
+ public void onReceivedHttpError(AwWebResourceRequest request, AwWebResourceResponse response) {
+ try {
+ TraceEvent.begin("WebViewContentsClientAdapter.onReceivedHttpError");
+ if (TRACE) Log.d(TAG, "onReceivedHttpError=" + request.url);
+ // TODO(mnaganov): Call mWebViewClient.onReceivedHttpError(mWebView, request, response);
+ } finally {
+ TraceEvent.end("WebViewContentsClientAdapter.onReceivedHttpError");
+ }
+ }
+
/**
* @see ContentViewClient#onReceivedTitle(String)
*/

Powered by Google App Engine
This is Rietveld 408576698