Http Cache: Update vary data after a 304.

Http Cache: Update vary data after a 304.

The request and response headers can change between the original request
and the requets that receives 304. Make sure the state of the cached entry
reflects the latest headers.

BUG=453306
TEST=net_unittests

Committed: https://crrev.com/28904d869ae7729c741eff8b59ca9343a3534d3c
Cr-Commit-Position: refs/heads/master@{#319709}

[rvargas (doing something else), 2015-03-05 23:20:47]

rvargas@chromium.org changed reviewers:
+ ricea@chromium.org

[Adam Rice, 2015-03-06 09:49:12]

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest.cc
File net/http/http_cache_unittest.cc (right):

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2216: transaction.request_headers = "Foo:
bar\r\n Name: bar\r\n";
What purpose does the space between \r\n and Name: serve?

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2237:
base::MessageLoop::current()->RunUntilIdle();
Optional: change these all to base::RunLoop().RunUntilIdle()

Even more optional: RunUntilActiveEntryGone() could be a method on MockHttpCache
?

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2283: // Tests that a 304 without vary headers
doesn't delete the previouysly stored
s/previouysly/previously/

Also in the following test.

[rvargas (doing something else), 2015-03-06 20:44:11]

Thanks

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest.cc
File net/http/http_cache_unittest.cc (right):

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2216: transaction.request_headers = "Foo:
bar\r\n Name: bar\r\n";
On 2015/03/06 09:49:11, Adam Rice wrote:
> What purpose does the space between \r\n and Name: serve?

Better readability. We skip white space when reading headers.

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2237:
base::MessageLoop::current()->RunUntilIdle();
On 2015/03/06 09:49:11, Adam Rice wrote:
> Optional: change these all to base::RunLoop().RunUntilIdle()
> 
> Even more optional: RunUntilActiveEntryGone() could be a method on
MockHttpCache
> ?

I couldn't come up with a name that makes me happy (a method promising something
that doesn't do) so I went with using RunLoop

https://codereview.chromium.org/976373005/diff/1/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:2283: // Tests that a 304 without vary headers
doesn't delete the previouysly stored
On 2015/03/06 09:49:12, Adam Rice wrote:
> s/previouysly/previously/
> 
> Also in the following test.

Done.

[Adam Rice, 2015-03-07 05:08:12]

lgtm

[rvargas (doing something else), 2015-03-09 17:51:36]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-03-09 17:52:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976373005/20001

[commit-bot: I haz the power, 2015-03-09 19:21:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 19:22:10]

Patchset 2 (id:??) landed as
https://crrev.com/28904d869ae7729c741eff8b59ca9343a3534d3c
Cr-Commit-Position: refs/heads/master@{#319709}