Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 976373003: Remove duplicate copy of animation/curves.dart in fn widgets (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove duplicate copy of animation/curves.dart in fn widgets Instead, we can just use the existing animation/curves.dart file in the framework. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/716aa28a6c0b4484b4604d25e5c1155667f8e379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M sky/examples/fn/widgets/animationgenerator.dart View 1 chunk +0 lines, -54 lines 0 comments Download
M sky/examples/fn/widgets/widgets.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-05 17:46:00 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-05 17:50:25 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-05 17:59:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
716aa28a6c0b4484b4604d25e5c1155667f8e379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698