LayoutTests/battery-status/multiple-promises-after-resolve.html - Issue 976373002: Return same promise consistently when using navigator.getBattery()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/battery-status/multiple-promises-after-resolve.html

Issue 976373002: Return same promise consistently when using navigator.getBattery() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase, make compile, fix comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/battery-status/multiple-promises.html ('k') | LayoutTests/battery-status/multiple-promises-after-resolve-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/battery-status/multiple-promises-after-resolve.html

diff --git a/LayoutTests/battery-status/multiple-promises-after-resolve.html b/LayoutTests/battery-status/multiple-promises-after-resolve.html

index d128f12667d4c25fb55532e03fe5d7af78b6c886..2e926fd58480266c746b3bda46ae801b1be80352 100644

--- a/LayoutTests/battery-status/multiple-promises-after-resolve.html

+++ b/LayoutTests/battery-status/multiple-promises-after-resolve.html

@@ -13,6 +13,7 @@ gc();

jsTestIsAsync = true;

testRunner.waitUntilDone();

+var promise1;

var mockBatteryInfo;

function setAndFireMockBatteryInfo(charging, chargingTime, dischargingTime, level) {

mockBatteryInfo = { charging: charging,

@@ -42,15 +43,18 @@ function batteryStatusSuccess(battery) {

debug('resolution number 1');

checkBatteryInfo(battery);

- navigator.getBattery().then(

+ promise2 = navigator.getBattery();

+ promise2.then(

function(battery) {

debug('resolution number 2');

checkBatteryInfo(battery);

setTimeout(finishJSTest, 0);

}, batteryStatusFailure);

+ shouldBeTrue('promise1 === promise2');

}

-navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

+promise1 = navigator.getBattery();

+promise1.then(batteryStatusSuccess, batteryStatusFailure);

setAndFireMockBatteryInfo(false, 10, 20, 0.5);

</script>

</body>