views: Cleanup PaintRestoredClientEdge() function.

views: Cleanup PaintRestoredClientEdge() function.

- Pass clang-format to make the code more readable, better indentation.
- Better docs.
- Reorganize the code to make more sense of the code flow.
- Use GetImageSkiaNamed() instead of calling ToImageSkia() everywhere.
- append _center prefix to some variables.

BUG=None
TEST=content_shell still works
R=jamescook@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238293

[tfarina, 2013-12-01 00:29:21]

Is that cleanup fine?

I think that will make easier to see the calculations we are doing there.

I've been looking at OpaqueBrowserFrameView::PaintRestoredClientEdge(), and
there we do more stuff than here in CustomFrameView.

Something there is doing the right thing to not paint the gray in the bottom
(I'll take a screenshot to make it easier to see what I'm talking about, I
thought there was a bug filed for this but I couldn't find), so with this I hope
to be going into the right direction.

I wanted to get this accepted as I first step towards this goal, but I don't
mind if it doesn't get accepted (although I will stay a bit sad I admit).

This was the result of me playing with this during this Saturday. 

Note that when I changed (in FrameBackground::PaintRestored()) from:
canvas->TileImageInt(*theme_image_,                                            
                     0, 0, view->width(), theme_image_->height());
To:
canvas->TileImageInt(*theme_image_,                                            
                     0, 0, view->width(), view->height());

It does paint everything in blue, but not the way we would expect, which is a
continuous paint. I know it is easier to explain with a screenshot, but I'm
tired to do this right now.

But since OpaqueBrowserFrameView does use FrameBackground as well, it means we
don't need to change that code in FrameBackground.

[James Cook, 2013-12-02 17:31:42]

LGTM

Recently I fixed a bug with windows having the wrong colors in the frame on
WinAura, see https://code.google.com/p/chromium/issues/detail?id=323318

[sadrul, 2013-12-02 17:39:20]

LGTM (just to confirm, this doesn't change any behaviour, right?)

[tfarina, 2013-12-02 18:43:52]

On 2013/12/02 17:39:20, sadrul wrote:
> LGTM (just to confirm, this doesn't change any behaviour, right?)

Yep, no behavior changes intended (yet).

[commit-bot: I haz the power, 2013-12-03 01:44:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/97633002/20001

[commit-bot: I haz the power, 2013-12-03 03:38:03]

Change committed as 238293