Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 976303002: Add some METADATA files to control docs layout. (Closed)

Created:
5 years, 9 months ago by jcgregorio
Modified:
5 years, 9 months ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add some METADATA files to control docs layout. BUG=skia:3484 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=976303002 Committed: https://skia.googlesource.com/skia/+/71b03e468d941984f600d6bca4e26e00e2af7756

Patch Set 1 #

Patch Set 2 : add docs #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A site/METADATA View 1 chunk +4 lines, -0 lines 0 comments Download
M site/dev/tools/markdown.md View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A site/user/METADATA View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jcgregorio
5 years, 9 months ago (2015-03-05 13:53:43 UTC) #2
hcm
One more nit on a comment for clarity, then LGTM https://codereview.chromium.org/976303002/diff/20001/site/dev/tools/markdown.md File site/dev/tools/markdown.md (right): https://codereview.chromium.org/976303002/diff/20001/site/dev/tools/markdown.md#newcode41 ...
5 years, 9 months ago (2015-03-05 14:38:30 UTC) #3
jcgregorio
https://codereview.chromium.org/976303002/diff/20001/site/dev/tools/markdown.md File site/dev/tools/markdown.md (right): https://codereview.chromium.org/976303002/diff/20001/site/dev/tools/markdown.md#newcode41 site/dev/tools/markdown.md:41: alphabetically in the navigation menu, with files appearing before ...
5 years, 9 months ago (2015-03-05 15:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976303002/40001
5 years, 9 months ago (2015-03-05 15:11:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 15:11:16 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/71b03e468d941984f600d6bca4e26e00e2af7756

Powered by Google App Engine
This is Rietveld 408576698