Telemetry: Add a decorator to inspector_backend.py

Telemetry: Add a decorator to inspector_backend.py

The decorator encapsulates common try/except logic in almost a dozen methods.

BUG=460625
Committed: https://crrev.com/546aefca672c92a477b433288f4af282b30cf5eb
Cr-Commit-Position: refs/heads/master@{#319507}

[erikchen, 2015-03-05 02:48:32]

erikchen@chromium.org changed reviewers:
+ slamm@chromium.org

[erikchen, 2015-03-05 02:48:32]

slamm: Please review.

[erikchen, 2015-03-05 17:39:05]

erikchen@chromium.org changed reviewers:
+ dtu@chromium.org

[erikchen, 2015-03-05 17:39:06]

dtu: Please review.

(since it looks like slamm doesn't do much reviewing in chromium codereview)

[slamm, 2015-03-05 17:59:55]

lgtm

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
(right):

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:25:
def _ConvertInspectorWebSocketExceptionIntoTelemetryException(func):
That name is a bit wordy. What about something like the following?

_HandleInspectorWebSocketExceptions

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:36:
backend = args[0]
backend -> inspector_backend

[slamm, 2015-03-05 18:00:26]

See what dtu thinks too.

On 2015/03/05 17:59:55, slamm wrote:
> lgtm
> 
>
https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
> File
> tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
> (right):
> 
>
https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
>
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:25:
> def _ConvertInspectorWebSocketExceptionIntoTelemetryException(func):
> That name is a bit wordy. What about something like the following?
> 
> _HandleInspectorWebSocketExceptions
> 
>
https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
>
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:36:
> backend = args[0]
> backend -> inspector_backend

[erikchen, 2015-03-05 18:19:12]

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
(right):

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:25:
def _ConvertInspectorWebSocketExceptionIntoTelemetryException(func):
On 2015/03/05 17:59:55, slamm wrote:
> That name is a bit wordy. What about something like the following?
> 
> _HandleInspectorWebSocketExceptions

Done.

https://codereview.chromium.org/976223002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:36:
backend = args[0]
On 2015/03/05 17:59:55, slamm wrote:
> backend -> inspector_backend

Done.

[dtu, 2015-03-06 19:03:05]

Neat! nits.

lgtm

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
(right):

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:31:
"""
for completeness: @functools.wraps(func)

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:32:
def inner(*args, **kwargs):
nit: func(inspector_backend, *args, **kwargs)

[erikchen, 2015-03-06 19:30:28]

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
(right):

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:31:
"""
On 2015/03/06 19:03:05, dtu wrote:
> for completeness: @functools.wraps(func)

Done.

https://codereview.chromium.org/976223002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py:32:
def inner(*args, **kwargs):
On 2015/03/06 19:03:05, dtu wrote:
> nit: func(inspector_backend, *args, **kwargs)

Done.

[erikchen, 2015-03-06 19:30:31]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-03-06 19:30:31]

The patchset sent to the CQ was uploaded after l-g-t-m from slamm@chromium.org,
dtu@chromium.org
Link to the patchset: https://codereview.chromium.org/976223002/#ps60001 (title:
"Comments from dtu.")

[commit-bot: I haz the power, 2015-03-06 19:31:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976223002/60001

[commit-bot: I haz the power, 2015-03-06 21:20:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-06 21:21:52]

Patchset 4 (id:??) landed as
https://crrev.com/546aefca672c92a477b433288f4af282b30cf5eb
Cr-Commit-Position: refs/heads/master@{#319507}