Fix bug where |i| was reused in a nested loop.

Fix bug where |i| was reused in a nested loop.

BUG=463794
Committed: https://crrev.com/ad9e147af655ac1fa09cb3bc12af9de22f15e4b1
Cr-Commit-Position: refs/heads/master@{#319206}

[hcarmona, 2015-03-05 01:53:56]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-03-05 02:04:39]

"""
Creating the FocusGrid and FocusRows when the devices are created gets rid of
the crash that was caused by iterating over the devices in the previous
location.
"""

why does this fix the hang and what does "previous location" mean in this
context?

[hcarmona, 2015-03-05 02:23:53]

On 2015/03/05 02:04:39, Dan Beam wrote:
> """
> Creating the FocusGrid and FocusRows when the devices are created gets rid of
> the crash that was caused by iterating over the devices in the previous
> location.
> """
> 
> why does this fix the hang and what does "previous location" mean in this
> context?

I completely missed the problem when I first looked at it. Took a second look
now and noticed the nested |i| declarations in the for loops. *face palm*

This CL is still a better change because it fixes another issue with the
lists' boundary because the "X more..." link isn't in the focus list but it's
inside the boundary so focus goes away from the list items and never returns.

I'll update the description for this CL to reflect that. There is no change to
the UI with the extra DIV, it's just so that the list and the "more" button
have different boundaries.

[Dan Beam, 2015-03-05 02:25:56]

https://codereview.chromium.org/976173003/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/other_devices.js (left):

https://codereview.chromium.org/976173003/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/other_devices.js:516: for (var i = 0; i <
rows.length; ++i) {
oh, this is the problem?  i'd just change i -> j here first so we can merge a
fix

[hcarmona, 2015-03-05 02:32:37]

On 2015/03/05 02:25:56, Dan Beam wrote:
>
https://codereview.chromium.org/976173003/diff/1/chrome/browser/resources/his...
> File chrome/browser/resources/history/other_devices.js (left):
> 
>
https://codereview.chromium.org/976173003/diff/1/chrome/browser/resources/his...
> chrome/browser/resources/history/other_devices.js:516: for (var i = 0; i <
> rows.length; ++i) {
> oh, this is the problem?  i'd just change i -> j here first so we can merge a
> fix

Done.

[Dan Beam, 2015-03-05 02:50:07]

lgtm

[hcarmona, 2015-03-05 02:51:59]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-03-05 02:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976173003/20001

[commit-bot: I haz the power, 2015-03-05 03:43:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-05 03:44:54]

Patchset 2 (id:??) landed as
https://crrev.com/ad9e147af655ac1fa09cb3bc12af9de22f15e4b1
Cr-Commit-Position: refs/heads/master@{#319206}