Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 976173002: Fix tests failures caused by issue 906493004. (Closed)

Created:
5 years, 9 months ago by Xi Han
Modified:
5 years, 9 months ago
Reviewers:
Devlin, Nico
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tests failures caused by issue 906493004 (https://codereview.chromium.org/906493004/). The failed tests were caused by missing the initialization of consumer_instance_type_ in UserScript. BUG=463906 TBR=rdevlin Committed: https://crrev.com/8806af42f41a804d3b4203dd042ce71983af886f Cr-Commit-Position: refs/heads/master@{#319207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M extensions/browser/user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/user_script.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/user_script.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Xi Han
Hi Nic: please take a look, thanks!
5 years, 9 months ago (2015-03-05 01:17:19 UTC) #2
Xi Han
Hi Devlin: Please review all changes, thanks!
5 years, 9 months ago (2015-03-05 01:27:58 UTC) #4
Nico
On 2015/03/05 01:27:58, Xi Han wrote: > Hi Devlin: Please review all changes, thanks! Lgtm
5 years, 9 months ago (2015-03-05 01:56:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976173002/1
5 years, 9 months ago (2015-03-05 01:57:35 UTC) #7
Nico
Rdevlin: still needs your seal of approvers for owners, I figured kicking the CQ will ...
5 years, 9 months ago (2015-03-05 01:59:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47430)
5 years, 9 months ago (2015-03-05 03:13:38 UTC) #10
Nico
IMA tbr it as it'll get our bots green.
5 years, 9 months ago (2015-03-05 03:40:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976173002/1
5 years, 9 months ago (2015-03-05 03:41:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 03:44:49 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 03:45:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8806af42f41a804d3b4203dd042ce71983af886f
Cr-Commit-Position: refs/heads/master@{#319207}

Powered by Google App Engine
This is Rietveld 408576698