Allow middle-click scrolling to work for PDFs and print preview

Allow middle-click scrolling to work for PDFs and print preview

This tells the plugin not to handle middle-click events so that they are
properly handled by the container page and allows middle-click scrolling
to work.

BUG=463399
Committed: https://crrev.com/78a82c836b6025a7d78753237a1b269927c90c9d
Cr-Commit-Position: refs/heads/master@{#319366}

[raymes, 2015-03-04 23:00:20]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2015-03-05 02:05:06]

https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
pdf/out_of_process_instance.cc:555: if (mouse_event.GetButton() ==
PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
What if the event isn't a mouse event?

[raymes, 2015-03-05 03:22:52]

On 2015/03/05 02:05:06, Sam McNally wrote:
>
https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
> File pdf/out_of_process_instance.cc (right):
> 
>
https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
> pdf/out_of_process_instance.cc:555: if (mouse_event.GetButton() ==
> PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
> What if the event isn't a mouse event?

Done.

[Sam McNally, 2015-03-05 06:20:37]

On 2015/03/05 03:22:52, raymes wrote:
> On 2015/03/05 02:05:06, Sam McNally wrote:
> >
>
https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
> > File pdf/out_of_process_instance.cc (right):
> > 
> >
>
https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
> > pdf/out_of_process_instance.cc:555: if (mouse_event.GetButton() ==
> > PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
> > What if the event isn't a mouse event?
> 
> Done.

Did you forget to upload a new patch set?

[raymes, 2015-03-05 23:06:56]

https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/976123002/diff/20001/pdf/out_of_process_insta...
pdf/out_of_process_instance.cc:555: if (mouse_event.GetButton() ==
PP_INPUTEVENT_MOUSEBUTTON_MIDDLE)
Oops, done.

[Sam McNally, 2015-03-05 23:08:06]

lgtm

[raymes, 2015-03-05 23:11:40]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2015-03-05 23:11:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976123002/40001

[commit-bot: I haz the power, 2015-03-05 23:53:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-05 23:54:25]

Patchset 3 (id:??) landed as
https://crrev.com/78a82c836b6025a7d78753237a1b269927c90c9d
Cr-Commit-Position: refs/heads/master@{#319366}