Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 976083003: Move the original Linkedin and Wowwiki page from key_mobile_sites to pathological_mobile_sites (Closed)

Created:
5 years, 9 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 9 months ago
Reviewers:
sullivan, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, picksi1, jdduke (slow), Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the original Linkedin and Wowwiki page from key_mobile_sites to pathological_mobile_sites In CL https://codereview.chromium.org/959063002/ we made the LinkedinIn and Wowwiki page in key_mobile_sites_smooth to reload before scrolling to take advantage of shader cache. This CL move the original non-reloading version of LinkedIn and Wowwiki to pathological_mobile_sites to track the long-term effort towards performance improvements without shader cache. WPR file for Linkedin and Wowwiki are re-recorded. BUG=430631, 453861 Committed: https://crrev.com/c78eec52a084cfd942acb9d4afe02285e271d342 Cr-Commit-Position: refs/heads/master@{#319359}

Patch Set 1 #

Patch Set 2 : re-record WPR file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/perf/page_sets/data/pathological_mobile_sites.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/pathological_mobile_sites_008.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/pathological_mobile_sites_009.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/pathological_mobile_sites.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Yufeng Shen (Slow to review)
Ned, please take a look. Simon, if this CL is submitted before your change https://codereview.chromium.org/964903002/ ...
5 years, 9 months ago (2015-03-04 21:59:17 UTC) #2
nednguyen
5 years, 9 months ago (2015-03-05 01:35:04 UTC) #4
nednguyen
On 2015/03/05 01:35:04, nednguyen wrote: Please don't copy the wpr. Those archives contain a lot ...
5 years, 9 months ago (2015-03-05 03:12:55 UTC) #5
picksi
For the related CL (https://codereview.chromium.org/964903002/) I am going to add some page interaction (to skip ...
5 years, 9 months ago (2015-03-05 11:03:19 UTC) #6
Yufeng Shen (Slow to review)
As agreed in email discussion, rerecording the WPR file is the best solution. I have ...
5 years, 9 months ago (2015-03-05 21:10:23 UTC) #7
sullivan
lgtm
5 years, 9 months ago (2015-03-05 21:19:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976083003/20001
5 years, 9 months ago (2015-03-05 22:09:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 23:32:43 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 23:33:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c78eec52a084cfd942acb9d4afe02285e271d342
Cr-Commit-Position: refs/heads/master@{#319359}

Powered by Google App Engine
This is Rietveld 408576698