Reenabling an old unit test for scrolling.

Reenabling an old unit test for scrolling.

BUG=

Committed: https://crrev.com/56c7e273f26c5454897357a98f2bdff438f4741d
Cr-Commit-Position: refs/heads/master@{#319281}

[cblume, 2015-03-04 20:26:14]

cblume@chromium.org changed reviewers:
+ nednguyen@google.com

[cblume, 2015-03-04 20:26:14]

Ned requested I move this to a separate patch, which I think is a good idea.

It is running against the try bots now to make sure I didn't miss anything.

[sullivan, 2015-03-04 20:27:51]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2015-03-04 20:27:51]

lgtm

(Swiping this since Ned is really busy this week).

Can you run locally before submitting on Android? We are working on getting
telemetry_unittests for Android on CQ, but they're not enabled yet.

[cblume, 2015-03-05 01:18:12]

I tested Android locally and noticed interesting results.

The test failed on Android, but only in portrait mode (tested Nexus 5 and Nexus
7). Both of the failures occurred because the scroll ended 2px off from the
bottom of the page. The test itself has a threshold in the comment "# Allow for
roundoff error in scaled viewport." and "self.assertTrue(abs(difference) <= 1
..."

Nexus 7, portrait      - AssertionError: scroll_position=2773;
scroll_height=2775
Nexus 7, landscape - passed
Nexus 5, portrait      - AssertionError: scroll_position=2847;
scroll_height=2849
Nexus 5, landscape - passed

I believe it is a bad idea to see if we have scrolled to the bottom of the page.
The test uses the default scroll speed for the default length of time. There is
no expectation that it will hit the bottom of the page.

I changed the test to check if it scrolled at all (which I believe is what the
test was supposed to check all along). It now passes on Android in both portrait
and landscape (Nexus 5 and Nexus 7).

[sullivan, 2015-03-05 03:03:59]

lgtm

Thanks for the careful testing!

https://codereview.chromium.org/976063003/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/actions/scroll_unittest.py (right):

https://codereview.chromium.org/976063003/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/actions/scroll_unittest.py:40:
"""(document.documentElement.scrollTop || document.body.scrollTop)""")
Nit: Don't need the triple quotes since this fits on one line now.

[cblume, 2015-03-05 17:55:22]

The CQ bit was checked by cblume@chromium.org

[cblume, 2015-03-05 17:55:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/976063003/#ps60001 (title:
"Making changes as per code review.")

[commit-bot: I haz the power, 2015-03-05 17:56:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976063003/60001

[cblume, 2015-03-05 17:56:53]

I fixed the nit. Thank you for pointing it out.

[commit-bot: I haz the power, 2015-03-05 18:01:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-05 18:01:51]

Patchset 4 (id:??) landed as
https://crrev.com/56c7e273f26c5454897357a98f2bdff438f4741d
Cr-Commit-Position: refs/heads/master@{#319281}