Fix exception for assignment to uninitialised const

Fix exception for assignment to uninitialised const

R=dslomov@chromium.org, mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/2ecdf736cf0409b52832f78a4439ace855d6739b
Cr-Commit-Position: refs/heads/master@{#27014}

[Michael Starzinger, 2015-03-04 14:28:58]

LGTM on the TurboFan port, didn't look at the rest.

[Dmitry Lomov (no reviews), 2015-03-04 17:57:35]

looks good, just a small comment

https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):

https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64...
src/arm64/full-codegen-arm64.cc:2450: } else if (var->mode() == CONST && op !=
Token::INIT_CONST) {
Looks like the case at line 2488 anymore should be CONST_LEGACY and not
INIT_CONST_LEGACY. Just remove IsSignallingAssignmentToConst altoghether.

https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-ar...
File src/arm/full-codegen-arm.cc (right):

https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-ar...
src/arm/full-codegen-arm.cc:2764: } else if (var->mode() == CONST && op !=
Token::INIT_CONST) {
Looks like the case at line 2800 anymore should be mode == CONST_LEGACY && op !=
INIT_CONST_LEGACY. 

Just remove IsSignallingAssignmentToConst altogether.

[rossberg, 2015-03-05 11:32:51]

On 2015/03/04 17:57:35, Dmitry Lomov (chromium) wrote:
> looks good, just a small comment
> 
>
https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64.cc
> File src/arm64/full-codegen-arm64.cc (right):
> 
>
https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64...
> src/arm64/full-codegen-arm64.cc:2450: } else if (var->mode() == CONST && op !=
> Token::INIT_CONST) {
> Looks like the case at line 2488 anymore should be CONST_LEGACY and not
> INIT_CONST_LEGACY. Just remove IsSignallingAssignmentToConst altoghether.
> 
>
https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-ar...
> File src/arm/full-codegen-arm.cc (right):
> 
>
https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-ar...
> src/arm/full-codegen-arm.cc:2764: } else if (var->mode() == CONST && op !=
> Token::INIT_CONST) {
> Looks like the case at line 2800 anymore should be mode == CONST_LEGACY && op
!=
> INIT_CONST_LEGACY. 
> 
> Just remove IsSignallingAssignmentToConst altogether.

Done.

[Dmitry Lomov (no reviews), 2015-03-05 11:51:58]

lgtm

[rossberg, 2015-03-05 12:18:58]

The CQ bit was checked by rossberg@chromium.org

[rossberg, 2015-03-05 12:18:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/976053002/#ps160001
(title: "Comments")

[commit-bot: I haz the power, 2015-03-05 12:19:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/976053002/160001

[commit-bot: I haz the power, 2015-03-05 12:44:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-03-05 12:44:08]

Patchset 9 (id:??) landed as
https://crrev.com/2ecdf736cf0409b52832f78a4439ace855d6739b
Cr-Commit-Position: refs/heads/master@{#27014}