Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: ipc/mojo/ipc_channel_mojo_unittest.cc

Issue 976043003: Fix a couple of ipc_channel_mojo_unittest failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a crbug.com link Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_channel_mojo_unittest.cc
diff --git a/ipc/mojo/ipc_channel_mojo_unittest.cc b/ipc/mojo/ipc_channel_mojo_unittest.cc
index c6d1894ec23180c0b83a14663407662fd2eaa67f..881744540d239aa3bf3192e1e1e62805b46e5a3d 100644
--- a/ipc/mojo/ipc_channel_mojo_unittest.cc
+++ b/ipc/mojo/ipc_channel_mojo_unittest.cc
@@ -431,7 +431,7 @@ TEST_F(IPCChannelMojoTest, SendMessagePipe) {
MULTIPROCESS_IPC_TEST_CLIENT_MAIN(IPCChannelMojoTestSendMessagePipeClient) {
ListenerThatExpectsMessagePipe listener;
- ChannelClient client(&listener, "IPCChannelMojoTestSendPlatformHandleClient");
+ ChannelClient client(&listener, "IPCChannelMojoTestSendMessagePipeClient");
client.Connect();
listener.set_sender(client.channel());
@@ -458,7 +458,7 @@ class IPCChannelMojoDeadHandleTest : public IPCChannelMojoTestBase {
const base::ProcessHandle client = client_process().Handle();
// Forces GetFileHandleForProcess() fail. It happens occasionally
// in production, so we should exercise it somehow.
- // TODO(morrita): figure out how to safely test this.
+ // TODO(morrita): figure out how to safely test this. See crbug.com/464109.
// ::CloseHandle(client);
host_->OnClientLaunched(client);
return true;
@@ -482,9 +482,11 @@ TEST_F(IPCChannelMojoDeadHandleTest, InvalidClientHandle) {
this->channel()->Close();
- // WaitForClientShutdown() fails as client_hanadle() is already
- // closed.
- EXPECT_FALSE(WaitForClientShutdown());
+ // TODO(morrita): We need CloseHandle() call in DidStartClient(),
+ // which has been disabled since crrev.com/843113003, to
+ // make this fail. See crbug.com/464109.
+ // EXPECT_FALSE(WaitForClientShutdown());
+ WaitForClientShutdown();
EXPECT_TRUE(listener.has_error());
DestroyChannel();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698