Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 976043003: Fix a couple of ipc_channel_mojo_unittest failures. (Closed)

Created:
5 years, 9 months ago by Hajime Morrita
Modified:
5 years, 9 months ago
Reviewers:
agl, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a couple of ipc_channel_mojo_unittest failures. This should've been covered by commit bot. The bot configuration chagne will come with a separate CL. R=viettrungluu@chromium.org, agl@chromium.org TEST=ipc_channel_mojo_unittest.cc BUG= Committed: https://crrev.com/e73c0b43a0fb4c8a93ba8e8155111a285294117f Cr-Commit-Position: refs/heads/master@{#319199}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Added a crbug.com link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ipc/mojo/ipc_channel_mojo_unittest.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Hajime Morrita
5 years, 9 months ago (2015-03-04 21:21:20 UTC) #1
viettrungluu
https://codereview.chromium.org/976043003/diff/1/ipc/mojo/ipc_channel_mojo_unittest.cc File ipc/mojo/ipc_channel_mojo_unittest.cc (right): https://codereview.chromium.org/976043003/diff/1/ipc/mojo/ipc_channel_mojo_unittest.cc#newcode485 ipc/mojo/ipc_channel_mojo_unittest.cc:485: // TODO(morrita): We need loseHandle() call on DidStartClient(), I ...
5 years, 9 months ago (2015-03-04 22:12:41 UTC) #2
Hajime Morrita
https://codereview.chromium.org/976043003/diff/1/ipc/mojo/ipc_channel_mojo_unittest.cc File ipc/mojo/ipc_channel_mojo_unittest.cc (right): https://codereview.chromium.org/976043003/diff/1/ipc/mojo/ipc_channel_mojo_unittest.cc#newcode485 ipc/mojo/ipc_channel_mojo_unittest.cc:485: // TODO(morrita): We need loseHandle() call on DidStartClient(), On ...
5 years, 9 months ago (2015-03-04 23:09:08 UTC) #3
viettrungluu
lgtm
5 years, 9 months ago (2015-03-05 01:11:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/976043003/20001
5 years, 9 months ago (2015-03-05 01:35:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-05 02:55:31 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:56:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e73c0b43a0fb4c8a93ba8e8155111a285294117f
Cr-Commit-Position: refs/heads/master@{#319199}

Powered by Google App Engine
This is Rietveld 408576698