Update Clear Key to support keyids formatted init_data

Update Clear Key to support keyids formatted init_data

BUG=442982
TEST=media_unittests pass

Committed: https://crrev.com/bbf8ee84c5969a74fd53d6c1b5ed5bd4fc831a37
Cr-Commit-Position: refs/heads/master@{#319180}

[jrummell, 2015-03-04 00:57:18]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2015-03-04 00:57:18]

PTAL.

[sandersd (OOO until July 31), 2015-03-04 01:04:21]

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc
File media/cdm/json_web_key.cc (right):

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc#ne...
media/cdm/json_web_key.cc:235: error_message->append(input);
Is it wise to have arbitrarily large error messages?

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc#ne...
media/cdm/json_web_key.cc:263: error_message->assign("Unable to access '");
Presumably this happens only when the value at that index is not a string.

[jrummell, 2015-03-04 01:28:53]

Updated.

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc
File media/cdm/json_web_key.cc (right):

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc#ne...
media/cdm/json_web_key.cc:235: error_message->append(input);
On 2015/03/04 01:04:21, sandersd wrote:
> Is it wise to have arbitrarily large error messages?

Good catch. Done.

https://codereview.chromium.org/975983002/diff/1/media/cdm/json_web_key.cc#ne...
media/cdm/json_web_key.cc:263: error_message->assign("Unable to access '");
On 2015/03/04 01:04:21, sandersd wrote:
> Presumably this happens only when the value at that index is not a string.

Done.

[sandersd (OOO until July 31), 2015-03-04 01:39:24]

lgtm

https://codereview.chromium.org/975983002/diff/20001/media/cdm/json_web_key.cc
File media/cdm/json_web_key.cc (right):

https://codereview.chromium.org/975983002/diff/20001/media/cdm/json_web_key.c...
media/cdm/json_web_key.cc:244:
error_message->append(ShortenTo64Characters(input));
I'm not too happy with this implementation when we know for a fact that the
string is not ASCII, but I don't have a better solution.

[jrummell, 2015-03-04 22:37:16]

Updated.

https://codereview.chromium.org/975983002/diff/20001/media/cdm/json_web_key.cc
File media/cdm/json_web_key.cc (right):

https://codereview.chromium.org/975983002/diff/20001/media/cdm/json_web_key.c...
media/cdm/json_web_key.cc:244:
error_message->append(ShortenTo64Characters(input));
On 2015/03/04 01:39:24, sandersd wrote:
> I'm not too happy with this implementation when we know for a fact that the
> string is not ASCII, but I don't have a better solution.

Found a routine to escape non-ASCII characters, so using it in
ShortenTo64Characters().

[ddorwin, 2015-03-04 22:46:52]

key_systems needs to be updated too.

https://codereview.chromium.org/975983002/diff/40001/media/cdm/json_web_key.h
File media/cdm/json_web_key.h (right):

https://codereview.chromium.org/975983002/diff/40001/media/cdm/json_web_key.h...
media/cdm/json_web_key.h:70: // Extracts the Key Ids from a Key IDs
Initialization Data
nit: This isn't technically JWK. I guess we have Clear Key code here already. We
might consider extracting the non-pure JWK[S] stuff in the future.

[jrummell, 2015-03-05 00:03:53]

Thanks for the reviews. I'll update key_systems when I add layout tests that
actually use it.

https://codereview.chromium.org/975983002/diff/40001/media/cdm/json_web_key.h
File media/cdm/json_web_key.h (right):

https://codereview.chromium.org/975983002/diff/40001/media/cdm/json_web_key.h...
media/cdm/json_web_key.h:70: // Extracts the Key Ids from a Key IDs
Initialization Data
On 2015/03/04 22:46:52, ddorwin wrote:
> nit: This isn't technically JWK. I guess we have Clear Key code here already.
We
> might consider extracting the non-pure JWK[S] stuff in the future.

Acknowledged. Maybe we should just rename this file to json_utils.

[jrummell, 2015-03-05 00:04:01]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2015-03-05 00:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/975983002/#ps40001 (title:
"escape non-ASCII")

[commit-bot: I haz the power, 2015-03-05 00:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975983002/40001

[commit-bot: I haz the power, 2015-03-05 00:56:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-05 00:57:21]

Patchset 3 (id:??) landed as
https://crrev.com/bbf8ee84c5969a74fd53d6c1b5ed5bd4fc831a37
Cr-Commit-Position: refs/heads/master@{#319180}