Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/mojo/src/mojo/public/dart/src/codec.dart

Issue 975973002: Update mojo sdk to rev f68e697e389943cd9bf9652397312280e96b127a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: shake fist at msvc Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/dart/src/codec.dart
diff --git a/third_party/mojo/src/mojo/public/dart/src/codec.dart b/third_party/mojo/src/mojo/public/dart/src/codec.dart
index 677dc10a7b33b1976f296db1939cc9f6c7faceb0..81c2523be53f4c53dd836b3320ecf3ae1abe5ac4 100644
--- a/third_party/mojo/src/mojo/public/dart/src/codec.dart
+++ b/third_party/mojo/src/mojo/public/dart/src/codec.dart
@@ -132,7 +132,7 @@ class Encoder {
void encodeUint8(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint8(_base + offset, value);
}
@@ -142,7 +142,7 @@ class Encoder {
void encodeUint16(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint16(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -152,7 +152,7 @@ class Encoder {
void encodeUint32(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint32(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -162,7 +162,7 @@ class Encoder {
void encodeUint64(int value, int offset) {
if (value < 0) {
- throw new MojoCodecError('$kErrorUnsigned: $val');
+ throw new MojoCodecError('$kErrorUnsigned: $value');
}
_buffer.buffer.setUint64(_base + offset, value, Endianness.LITTLE_ENDIAN);
}
@@ -208,13 +208,13 @@ class Encoder {
encodeMessagePipeHandle(pipe.endpoints[1], offset, nullable);
}
- void encodeInterfaceRequest(Proxy client, int offset, bool nullable) {
+ void encodeInterfaceRequest(ProxyBase client, int offset, bool nullable) {
if (client == null) {
encodeInvalideHandle(offset, nullable);
return;
}
var pipe = new core.MojoMessagePipe();
- client.bind(pipe.endpoints[0]);
+ client.impl.bind(pipe.endpoints[0]);
encodeMessagePipeHandle(pipe.endpoints[1], offset, nullable);
}
@@ -483,10 +483,10 @@ class Encoder {
void appendUint64Array(List<int> value) =>
appendBytes(new Uint8List.view(new Uint64List.fromList(value).buffer));
- void appendFloatArray(List<int> value) =>
+ void appendFloatArray(List<double> value) =>
appendBytes(new Uint8List.view(new Float32List.fromList(value).buffer));
- void appendDoubleArray(List<int> value) =>
+ void appendDoubleArray(List<double> value) =>
appendBytes(new Uint8List.view(new Float64List.fromList(value).buffer));
Encoder encoderForMap(int offset) {
@@ -601,7 +601,7 @@ class Decoder {
core.MojoSharedBuffer decodeSharedBufferHandle(int offset, bool nullable) =>
new core.MojoSharedBuffer(decodeHandle(offset, nullable));
- Proxy decodeServiceInterface(
+ ProxyBase decodeServiceInterface(
int offset, bool nullable, Function clientFactory) {
var endpoint = decodeMessagePipeHandle(offset, nullable);
return endpoint.handle.isValid ? clientFactory(endpoint) : null;
@@ -697,7 +697,7 @@ class Decoder {
ArrayDataHeader decodeDataHeaderForArray(int elementSize,
int expectedLength) {
var header = decodeArrayDataHeader();
- var arrayByteCount =
+ var arrayByteCount =
ArrayDataHeader.kHeaderSize + header.numElements * elementSize;
if (header.size < arrayByteCount) {
throw new MojoCodecError(

Powered by Google App Engine
This is Rietveld 408576698