Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/mojo/src/mojo/public/dart/rules.gni

Issue 975973002: Update mojo sdk to rev f68e697e389943cd9bf9652397312280e96b127a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: shake fist at msvc Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mojo/src/mojo/public/dart/rules.gni
diff --git a/third_party/mojo/src/mojo/public/dart/rules.gni b/third_party/mojo/src/mojo/public/dart/rules.gni
index 5845f2e5c096746439eb1bb3c36b67866374f7aa..e8d7c7274be59b03a7f21ebfc6465a88281de9cc 100644
--- a/third_party/mojo/src/mojo/public/dart/rules.gni
+++ b/third_party/mojo/src/mojo/public/dart/rules.gni
@@ -54,6 +54,7 @@ template("dart_package") {
# dart_package targets.
template("dart_packaged_application") {
package_name = "${target_name}_package"
+ package_analyze_sources = "${target_name}_analyze"
package_output = "$target_out_dir/$package_name.dartzip"
if (defined(invoker.output_name)) {
@@ -62,6 +63,39 @@ template("dart_packaged_application") {
mojo_output = "$root_out_dir/" + target_name + ".mojo"
}
+ action_foreach(package_analyze_sources) {
+ sources = invoker.sources
+
+ script = rebase_path("mojo/public/tools/dart_analyze.py", ".", mojo_root)
+
+ args = [
+ rebase_path(root_gen_dir),
+ rebase_path("$target_gen_dir/{{source_name_part}}.stamp"),
+ "{{source}}",
+ "--no-hints",
+ "--url-mapping=mojo:application,/" +
+ rebase_path("mojo/public/dart/application.dart", "/", mojo_root),
+ "--url-mapping=mojo:bindings,/" +
+ rebase_path("mojo/public/dart/bindings.dart", "/", mojo_root),
+ "--url-mapping=mojo:builtin,/" +
+ rebase_path("mojo/dart/embedder/builtin.dart", "/", mojo_root),
+ "--url-mapping=mojo:core,/" +
+ rebase_path("mojo/public/dart/core.dart", "/", mojo_root),
+ ]
+
+ if (defined(invoker.deps)) {
+ deps = invoker.deps
+ }
+
+ if (defined(invoker.datadeps)) {
+ datadeps = invoker.datadeps
+ }
+
+ outputs = [
+ "$target_gen_dir/{{source_name_part}}.stamp",
+ ]
+ }
+
dart_package(package_name) {
sources = invoker.sources
if (defined(invoker.deps)) {
@@ -89,6 +123,9 @@ template("dart_packaged_application") {
]
deps = [
+ # TODO(erg): When dartanalyze runs at an acceptable speed, add
+ # ":$package_analyze_sources" as a dependency here and remove the
+ # manual group("check") in the toplevel build file.
":$package_name",
]
if (defined(invoker.deps)) {
@@ -102,7 +139,7 @@ template("dart_packaged_application") {
}
line = "#!mojo mojo:dart_content_handler"
- if (defined(invoker.strict) && invoker.strict == true) {
+ if (is_debug || (defined(invoker.strict) && invoker.strict == true)) {
line = "#!mojo mojo:dart_content_handler?strict=true"
}
« no previous file with comments | « third_party/mojo/src/mojo/public/dart/bindings.dart ('k') | third_party/mojo/src/mojo/public/dart/src/application.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698