third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc - Issue 975973002: Update mojo sdk to rev f68e697e389943cd9bf9652397312280e96b127a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 975973002: Update mojo sdk to rev f68e697e389943cd9bf9652397312280e96b127a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: shake fist at msvc Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/cpp/bindings/lib/interface_ptr_internal.h ('k') | third_party/mojo/src/mojo/public/cpp/bindings/tests/validation_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

diff --git a/third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc b/third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

index 3fcade67fd823a2c1259de54df96ddc7841a9f30..524b07c64d2e750e2eadb2cca09f52ff41f6d423 100644

--- a/third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

+++ b/third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

@@ -261,6 +261,16 @@ TEST_F(InterfacePtrTest, Resettable) {

EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, CloseRaw(handle));

}

+TEST_F(InterfacePtrTest, BindInvalidHandle) {

+ math::CalculatorPtr ptr;

+ EXPECT_FALSE(ptr.get());

+ EXPECT_FALSE(ptr);

+ ptr.Bind(ScopedMessagePipeHandle());

+ EXPECT_FALSE(ptr.get());

+ EXPECT_FALSE(ptr);

TEST_F(InterfacePtrTest, EncounteredError) {

math::CalculatorPtr proxy;

MathCalculatorImpl calc_impl(GetProxy(&proxy));