Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 975963002: Catch exception if --adb-key-files file does not exist and log warning. (Closed)

Created:
5 years, 9 months ago by navabi
Modified:
5 years, 9 months ago
Reviewers:
friedman, jbudorick, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch exception if --adb-key-files file does not exist and log warning. BUG= Committed: https://crrev.com/101326f95ee0cb7a68d1e337d9966fe4bc9cf9cc Cr-Commit-Position: refs/heads/master@{#318999}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unnecessary import glob. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/provision_devices.py View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
navabi
Please review with this CL: https://codereview.chromium.org/976913002/
5 years, 9 months ago (2015-03-04 00:20:06 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/975963002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/975963002/diff/1/build/android/provision_devices.py#newcode14 build/android/provision_devices.py:14: import glob nit: remove this
5 years, 9 months ago (2015-03-04 00:20:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975963002/20001
5 years, 9 months ago (2015-03-04 00:27:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 02:14:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:15:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/101326f95ee0cb7a68d1e337d9966fe4bc9cf9cc
Cr-Commit-Position: refs/heads/master@{#318999}

Powered by Google App Engine
This is Rietveld 408576698