Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 975943002: Implemented screen rotation animation experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mukai@'s comments from patch set 1. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 const Experiment::Choice kFillOnAccountSelectChoices[] = { 409 const Experiment::Choice kFillOnAccountSelectChoices[] = {
410 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 410 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
411 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 411 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
412 autofill::switches::kDisableFillOnAccountSelect, "" }, 412 autofill::switches::kDisableFillOnAccountSelect, "" },
413 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_HIGHLIGHTING, 413 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_HIGHLIGHTING,
414 autofill::switches::kEnableFillOnAccountSelect, "" }, 414 autofill::switches::kEnableFillOnAccountSelect, "" },
415 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_NO_HIGHLIGHTING, 415 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_NO_HIGHLIGHTING,
416 autofill::switches::kEnableFillOnAccountSelectNoHighlighting, "" }, 416 autofill::switches::kEnableFillOnAccountSelectNoHighlighting, "" },
417 }; 417 };
418 418
419 #if defined(USE_ASH)
420 const Experiment::Choice kAshScreenRotationAnimationChoices[] = {
421 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, "", "" },
422 { IDS_ASH_SCREEN_ROTATION_ANIMATION_PARTIAL_ROTATION,
423 ash::switches::kAshEnableScreenRotationAnimation, "partial-rotation" },
424 { IDS_ASH_SCREEN_ROTATION_ANIMATION_PARTIAL_ROTATION_SLOW,
425 ash::switches::kAshEnableScreenRotationAnimation, "partial-rotation-slow" },
426 { IDS_ASH_SCREEN_ROTATION_ANIMATION_FULL_ROTATION,
427 ash::switches::kAshEnableScreenRotationAnimation, "full-rotation" },
428 { IDS_ASH_SCREEN_ROTATION_ANIMATION_FULL_ROTATION_SLOW,
429 ash::switches::kAshEnableScreenRotationAnimation, "full-rotation-slow" }
430 };
431 #endif
432
419 // RECORDING USER METRICS FOR FLAGS: 433 // RECORDING USER METRICS FOR FLAGS:
420 // ----------------------------------------------------------------------------- 434 // -----------------------------------------------------------------------------
421 // The first line of the experiment is the internal name. If you'd like to 435 // The first line of the experiment is the internal name. If you'd like to
422 // gather statistics about the usage of your flag, you should append a marker 436 // gather statistics about the usage of your flag, you should append a marker
423 // comment to the end of the feature name, like so: 437 // comment to the end of the feature name, like so:
424 // "my-special-feature", // FLAGS:RECORD_UMA 438 // "my-special-feature", // FLAGS:RECORD_UMA
425 // 439 //
426 // After doing that, run 440 // After doing that, run
427 // tools/metrics/actions/extract_actions.py 441 // tools/metrics/actions/extract_actions.py
428 // to add the metric to actions.xml (which will enable UMA to record your 442 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
972 IDS_FLAGS_DISABLE_TOUCH_FEEDBACK_DESCRIPTION, 986 IDS_FLAGS_DISABLE_TOUCH_FEEDBACK_DESCRIPTION,
973 kOsCrOS, 987 kOsCrOS,
974 SINGLE_VALUE_TYPE(switches::kDisableTouchFeedback), 988 SINGLE_VALUE_TYPE(switches::kDisableTouchFeedback),
975 }, 989 },
976 { "ash-enable-mirrored-screen", 990 { "ash-enable-mirrored-screen",
977 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_NAME, 991 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_NAME,
978 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_DESCRIPTION, 992 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_DESCRIPTION,
979 kOsCrOS, 993 kOsCrOS,
980 SINGLE_VALUE_TYPE(ash::switches::kAshEnableMirroredScreen), 994 SINGLE_VALUE_TYPE(ash::switches::kAshEnableMirroredScreen),
981 }, 995 },
996 {
997 "ash-enable-screen-rotation-animations",
998 IDS_FLAGS_ASH_ENABLE_SCREEN_ROTATION_ANIMATION_NAME,
999 IDS_FLAGS_ASH_ENABLE_SCREEN_ROTATION_ANIMATION_DESCRIPTION,
1000 kOsCrOS,
1001 MULTI_VALUE_TYPE(kAshScreenRotationAnimationChoices)
1002 },
982 #endif // defined(USE_ASH) 1003 #endif // defined(USE_ASH)
983 #if defined(OS_CHROMEOS) 1004 #if defined(OS_CHROMEOS)
984 { 1005 {
985 "enable-carrier-switching", 1006 "enable-carrier-switching",
986 IDS_FLAGS_ENABLE_CARRIER_SWITCHING, 1007 IDS_FLAGS_ENABLE_CARRIER_SWITCHING,
987 IDS_FLAGS_ENABLE_CARRIER_SWITCHING_DESCRIPTION, 1008 IDS_FLAGS_ENABLE_CARRIER_SWITCHING_DESCRIPTION,
988 kOsCrOS, 1009 kOsCrOS,
989 SINGLE_VALUE_TYPE(chromeos::switches::kEnableCarrierSwitching) 1010 SINGLE_VALUE_TYPE(chromeos::switches::kEnableCarrierSwitching)
990 }, 1011 },
991 { 1012 {
(...skipping 1732 matching lines...) Expand 10 before | Expand all | Expand 10 after
2724 } 2745 }
2725 2746
2726 const Experiment* GetExperiments(size_t* count) { 2747 const Experiment* GetExperiments(size_t* count) {
2727 *count = num_experiments; 2748 *count = num_experiments;
2728 return experiments; 2749 return experiments;
2729 } 2750 }
2730 2751
2731 } // namespace testing 2752 } // namespace testing
2732 2753
2733 } // namespace about_flags 2754 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698