Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Issue 975933002: Return reference from styleEngine() accessor. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, Rik, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gavinp+prerender_chromium.org, gyuyoung.kim_webkit.org, jchaffraix+rendering, Justin Novosad, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, sof, webcomponents-bugzilla_chromium.org, Yoav Weiss, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return reference from styleEngine() accessor. The m_styleEngine member of Document is created in the constructor and only cleared when the OwnPtr goes out of scope as Document is destroyed. Changed the styleEngine() accessor to return a reference with an ASSERT checking that it is never null. Removed null checks in Document::~Document() and styleResolverChanged() where the styleEngine cannot be null. Removed the clearStyleResolver method from Document since it was only used inside the Document implementation. R=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -157 lines) Patch
M Source/core/css/AffectedByFocusTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/FontBuilderTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 17 chunks +21 lines, -32 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/StyleElement.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBR.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutInline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObjectInlines.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/InjectedStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
5 years, 9 months ago (2015-03-04 09:28:45 UTC) #1
dglazkov
lgtm
5 years, 9 months ago (2015-03-04 18:23:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975933002/1
5 years, 9 months ago (2015-03-04 18:33:01 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:57:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191302

Powered by Google App Engine
This is Rietveld 408576698