Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 97593002: Add tests for C++11's std::rethrow_exception() (dependent exceptions) (Closed)

Created:
7 years ago by Mark Seaborn
Modified:
7 years ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add tests for C++11's std::rethrow_exception() (dependent exceptions) The first two tests added here test for bugs in eh_pnacl.cc (PNaCl SJLJ EH support) in libsupc++, for which I've committed fixes. The third test tests for a potential bug but I've never seen it fail with libsupc++. All three tests passed first time with my SJLJ EH change for libcxxabi, which is because libcxxabi's __cxa_exception and __cxa_dependent_exception have matching layouts (with an exceptionType field at the same offset), unlike in libsupc++. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3696 TEST=run_eh_throw_tests_sjlj_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12473

Patch Set 1 #

Patch Set 2 : Retry upload #

Patch Set 3 : More coverage #

Patch Set 4 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -3 lines) Patch
M tests/toolchain/eh_throw_tests.cc View 1 2 3 2 chunks +92 lines, -0 lines 0 comments Download
M tests/toolchain/nacl.scons View 1 2 3 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
7 years ago (2013-12-02 20:47:32 UTC) #1
Derek Schuff
lgtm
7 years ago (2013-12-02 21:55:55 UTC) #2
Mark Seaborn
I've tweaked this to use CXXFLAGS=['-std=gnu++11'] instead of CCFLAGS=['-std=c++11'] because the latter breaks .c files ...
7 years ago (2013-12-03 03:40:13 UTC) #3
Mark Seaborn
7 years ago (2013-12-03 03:42:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r12473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698