Don't hardcode the list of events types in fn

sky/examples/fn/lib/node.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 part of fn;
 
 void _parentInsertBefore(sky.ParentNode parent,
                          sky.Node node,
                          sky.Node ref) {
   if (ref != null) {
     ref.insertBefore([node]);
   } else {
     parent.appendChild(node);
   }
 }
 
 abstract class Node {
   String _key = null;
   sky.Node _root = null;
 
+  // TODO(abarth): Both Elements and Components have |events| but |Text|
+  // doesn't. Should we add a common base class to contain |events|?
+  final EventMap events = new EventMap();
+
   Node({ Object key }) {
     _key = key == null ? "$runtimeType" : "$runtimeType-$key";
   }
 
   // Return true IFF the old node has *become* the new node (should be
   // retained because it is stateful)
   bool _sync(Node old, sky.ParentNode host, sky.Node insertBefore);
 
   void _remove() {
     assert(_root != null);
@@ skipping 27 matching lines @@
 final List<Node> _emptyList = new List<Node>();
 
 abstract class Element extends Node {
 
   String get _tagName;
 
   Element get _emptyElement;
 
   String inlineStyle;
 
-  sky.EventListener onClick;
-  sky.EventListener onFlingCancel;
-  sky.EventListener onFlingStart;
-  sky.EventListener onGestureTap;
-  sky.EventListener onPointerCancel;
-  sky.EventListener onPointerDown;
-  sky.EventListener onPointerMove;
-  sky.EventListener onPointerUp;
-  sky.EventListener onScrollEnd;
-  sky.EventListener onScrollStart;
-  sky.EventListener onScrollUpdate;
-  sky.EventListener onWheel;
-
   List<Node> _children = null;
   String _className = '';
 
   Element({
     Object key,
     List<Node> children,
     Style style,
 
-    this.inlineStyle,
-
-    // Events
-    this.onClick,
-    this.onFlingCancel,
-    this.onFlingStart,
-    this.onGestureTap,
-    this.onPointerCancel,
-    this.onPointerDown,
-    this.onPointerMove,
-    this.onPointerUp,
-    this.onScrollEnd,
-    this.onScrollStart,
-    this.onScrollUpdate,
-    this.onWheel
+    this.inlineStyle
   }) : super(key:key) {
 
     _className = style == null ? '': style._className;
     _children = children == null ? _emptyList : children;
 
     if (_debugWarnings()) {
       _debugReportDuplicateIds();
     }
   }
 
@@ skipping 14 matching lines @@
         continue; // Text nodes all have the same key and are never reordered.
       }
 
       if (!idSet.add(child._key)) {
         throw '''If multiple (non-Text) nodes of the same type exist as children
                  of another node, they must have unique keys.''';
       }
     }
   }
 
-  void _syncEvent(String eventName, sky.EventListener listener,
-                  sky.EventListener oldListener) {
-    sky.Element root = _root as sky.Element;
-    if (listener == oldListener)
-      return;
-
-    if (oldListener != null) {
-      root.removeEventListener(eventName, oldListener);
-    }
-
-    if (listener != null) {
-      root.addEventListener(eventName, listener);
-    }
-  }
-
   void _syncEvents([Element old]) {
-    _syncEvent('click', onClick, old.onClick);
-    _syncEvent('gestureflingcancel', onFlingCancel, old.onFlingCancel);
-    _syncEvent('gestureflingstart', onFlingStart, old.onFlingStart);
-    _syncEvent('gesturescrollend', onScrollEnd, old.onScrollEnd);
-    _syncEvent('gesturescrollstart', onScrollStart, old.onScrollStart);
-    _syncEvent('gesturescrollupdate', onScrollUpdate, old.onScrollUpdate);
-    _syncEvent('gesturetap', onGestureTap, old.onGestureTap);
-    _syncEvent('pointercancel', onPointerCancel, old.onPointerCancel);
-    _syncEvent('pointerdown', onPointerDown, old.onPointerDown);
-    _syncEvent('pointermove', onPointerMove, old.onPointerMove);
-    _syncEvent('pointerup', onPointerUp, old.onPointerUp);
-    _syncEvent('wheel', onWheel, old.onWheel);
+    List<EventHandler> newHandlers = events._handlers;
+    int newStartIndex = 0;
+    int newEndIndex = newHandlers.length;
+
+    List<EventHandler> oldHandlers = old.events._handlers;
+    int oldStartIndex = 0;
+    int oldEndIndex = oldHandlers.length;
+
+    // Skip over leading handlers that match.
+    while (newStartIndex < newEndIndex && oldStartIndex < oldEndIndex) {
+      EventHandler newHander = newHandlers[newStartIndex];
+      EventHandler oldHandler = oldHandlers[oldStartIndex];
+      if (newHander.type != oldHandler.type
+          || newHander.listener != oldHandler.listener)
+        break;
+      ++newStartIndex;
+      ++oldStartIndex;
+    }
+
+    // Skip over trailing handlers that match.
+    while (newStartIndex < newEndIndex && oldStartIndex < oldEndIndex) {
+      EventHandler newHander = newHandlers[newEndIndex - 1];
+      EventHandler oldHandler = oldHandlers[oldEndIndex - 1];
+      if (newHander.type != oldHandler.type
+          || newHander.listener != oldHandler.listener)
+        break;
+      --newEndIndex;
+      --oldEndIndex;
+    }
+
+    sky.Element root = _root as sky.Element;
+
+    for (int i = oldStartIndex; i < oldEndIndex; ++i) {
+      EventHandler oldHandler = oldHandlers[i];
+      root.removeEventListener(oldHandler.type, oldHandler.listener);
+    }
+
+    for (int i = newStartIndex; i < newEndIndex; ++i) {
+      EventHandler newHander = newHandlers[i];
+      root.addEventListener(newHander.type, newHander.listener);
+    }
   }
 
   void _syncNode([Element old]) {
     if (old == null) {
       old = _emptyElement;
     }
 
     _syncEvents(old);
 
     sky.Element root = _root as sky.Element;
@@ skipping 173 matching lines @@
   String get _tagName => 'div';
 
   static final Container _emptyContainer = new Container();
 
   Element get _emptyElement => _emptyContainer;
 
   Container({
     Object key,
     List<Node> children,
     Style style,
-    String inlineStyle,
-    sky.EventListener onClick,
-    sky.EventListener onFlingCancel,
-    sky.EventListener onFlingStart,
-    sky.EventListener onGestureTap,
-    sky.EventListener onPointerCancel,
-    sky.EventListener onPointerDown,
-    sky.EventListener onPointerMove,
-    sky.EventListener onPointerUp,
-    sky.EventListener onScrollEnd,
-    sky.EventListener onScrollStart,
-    sky.EventListener onScrollUpdate,
-    sky.EventListener onWheel
+    String inlineStyle
   }) : super(
     key: key,
     children: children,
     style: style,
-    inlineStyle: inlineStyle,
-    onClick: onClick,
-    onFlingCancel: onFlingCancel,
-    onFlingStart: onFlingStart,
-    onGestureTap: onGestureTap,
-    onPointerCancel: onPointerCancel,
-    onPointerDown: onPointerDown,
-    onPointerMove: onPointerMove,
-    onPointerUp: onPointerUp,
-    onScrollEnd: onScrollEnd,
-    onScrollStart: onScrollStart,
-    onScrollUpdate: onScrollUpdate,
-    onWheel: onWheel
+    inlineStyle: inlineStyle
   );
 }
 
 class Image extends Element {
 
   String get _tagName => 'img';
 
   static final Image _emptyImage = new Image();
   Element get _emptyElement => _emptyImage;
 
   String src;
   int width;
   int height;
 
   Image({
     Object key,
     List<Node> children,
     Style style,
     String inlineStyle,
-    sky.EventListener onClick,
-    sky.EventListener onFlingCancel,
-    sky.EventListener onFlingStart,
-    sky.EventListener onGestureTap,
-    sky.EventListener onPointerCancel,
-    sky.EventListener onPointerDown,
-    sky.EventListener onPointerMove,
-    sky.EventListener onPointerUp,
-    sky.EventListener onScrollEnd,
-    sky.EventListener onScrollStart,
-    sky.EventListener onScrollUpdate,
-    sky.EventListener onWheel,
     this.width,
     this.height,
     this.src
   }) : super(
     key: key,
     children: children,
     style: style,
-    inlineStyle: inlineStyle,
-    onClick: onClick,
-    onFlingCancel: onFlingCancel,
-    onFlingStart: onFlingStart,
-    onGestureTap: onGestureTap,
-    onPointerCancel: onPointerCancel,
-    onPointerDown: onPointerDown,
-    onPointerMove: onPointerMove,
-    onPointerUp: onPointerUp,
-    onScrollEnd: onScrollEnd,
-    onScrollStart: onScrollStart,
-    onScrollUpdate: onScrollUpdate,
-    onWheel: onWheel
+    inlineStyle: inlineStyle
   );
 
   void _syncNode([Element old]) {
     super._syncNode(old);
 
     Image oldImage = old != null ? old : _emptyImage;
     sky.HTMLImageElement skyImage = _root as sky.HTMLImageElement;
     if (src != oldImage.src) {
       skyImage.src = src;
     }
@@ skipping 13 matching lines @@
 
   static final Anchor _emptyAnchor = new Anchor();
 
   String href;
 
   Anchor({
     Object key,
     List<Node> children,
     Style style,
     String inlineStyle,
-    sky.EventListener onClick,
-    sky.EventListener onFlingCancel,
-    sky.EventListener onFlingStart,
-    sky.EventListener onGestureTap,
-    sky.EventListener onPointerCancel,
-    sky.EventListener onPointerDown,
-    sky.EventListener onPointerMove,
-    sky.EventListener onPointerUp,
-    sky.EventListener onScrollEnd,
-    sky.EventListener onScrollStart,
-    sky.EventListener onScrollUpdate,
-    sky.EventListener onWheel,
     this.width,
     this.height,
     this.href
   }) : super(
     key: key,
     children: children,
     style: style,
-    inlineStyle: inlineStyle,
-    onClick: onClick,
-    onFlingCancel: onFlingCancel,
-    onFlingStart: onFlingStart,
-    onGestureTap: onGestureTap,
-    onPointerCancel: onPointerCancel,
-    onPointerDown: onPointerDown,
-    onPointerMove: onPointerMove,
-    onPointerUp: onPointerUp,
-    onScrollEnd: onScrollEnd,
-    onScrollStart: onScrollStart,
-    onScrollUpdate: onScrollUpdate,
-    onWheel: onWheel
+    inlineStyle: inlineStyle
   );
 
   void _syncNode([Element old]) {
     Anchor oldAnchor = old != null ? old as Anchor : _emptyAnchor;
     super._syncNode(oldAnchor);
 
     sky.HTMLAnchorElement skyAnchor = _root as sky.HTMLAnchorElement;
     if (href != oldAnchor.href) {
       skyAnchor.href = href;
     }
   }
 }