Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 975773002: [Ozone-Dri] Make GbmDevice destructor private (Closed)

Created:
5 years, 9 months ago by vignatti (out of this project)
Modified:
5 years, 9 months ago
Reviewers:
*dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Dri] Make GbmDevice destructor private It fixes the following clang format message: In file included from ../../ui/ozone/platform/dri/gbm_buffer.cc:14: ../../ui/ozone/platform/dri/gbm_device.h:18:3: error: [chromium-style] Classes that are ref-counted should have destructors that are declared protected or private. ~GbmDevice() override; ^ ../../ui/ozone/platform/dri/gbm_device.h:14:19: note: [chromium-style] 'GbmDevice' inherits from 'ui::DrmDevice' here class GbmDevice : public DrmDevice { ^ ../../ui/ozone/platform/dri/drm_device.h:41:32: note: [chromium-style] 'DrmDevice' inherits from 'base::RefCountedThreadSafe<DrmDevice>' here class OZONE_EXPORT DrmDevice : public base::RefCountedThreadSafe<DrmDevice> { BUG=none Committed: https://crrev.com/a01795d72ee7d0f5b1d5acdcfcc67918b0e4d4c1 Cr-Commit-Position: refs/heads/master@{#318899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/ozone/platform/dri/gbm_device.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vignatti (out of this project)
PTAL.
5 years, 9 months ago (2015-03-03 16:54:10 UTC) #3
dnicoara
lgtm
5 years, 9 months ago (2015-03-03 16:55:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975773002/1
5 years, 9 months ago (2015-03-03 16:56:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 17:32:10 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 17:32:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a01795d72ee7d0f5b1d5acdcfcc67918b0e4d4c1
Cr-Commit-Position: refs/heads/master@{#318899}

Powered by Google App Engine
This is Rietveld 408576698