Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: Source/core/layout/style/SVGLayoutStyle.h

Issue 975733002: Use Length for the stroke-dasharray property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add test for style-change responsive-ness. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/style/SVGLayoutStyle.h
diff --git a/Source/core/layout/style/SVGLayoutStyle.h b/Source/core/layout/style/SVGLayoutStyle.h
index 842473863e461255af6024e5acfccbc89a64377a..29f3540c5af1e2cdc3dc453d6e3c5c3cb7987efd 100644
--- a/Source/core/layout/style/SVGLayoutStyle.h
+++ b/Source/core/layout/style/SVGLayoutStyle.h
@@ -75,7 +75,7 @@ public:
static SVGPaintType initialStrokePaintType() { return SVG_PAINTTYPE_NONE; }
static Color initialStrokePaintColor() { return Color(); }
static String initialStrokePaintUri() { return String(); }
- static PassRefPtrWillBeRawPtr<SVGLengthList> initialStrokeDashArray() { return SVGLengthList::create(); }
+ static PassRefPtr<SVGDashArray> initialStrokeDashArray();
static Length initialStrokeDashOffset() { return Length(Fixed); }
static float initialStrokeMiterLimit() { return 4; }
static float initialStopOpacity() { return 1; }
@@ -195,10 +195,10 @@ public:
}
}
- void setStrokeDashArray(PassRefPtrWillBeRawPtr<SVGLengthList> obj)
+ void setStrokeDashArray(PassRefPtr<SVGDashArray> dashArray)
{
- if (*stroke->dashArray != *obj)
- stroke.access()->dashArray = obj;
+ if (*stroke->dashArray != *dashArray)
+ stroke.access()->dashArray = dashArray;
}
void setStrokeMiterLimit(float obj)
@@ -319,7 +319,7 @@ public:
const SVGPaintType& strokePaintType() const { return stroke->paintType; }
const Color& strokePaintColor() const { return stroke->paintColor; }
const String& strokePaintUri() const { return stroke->paintUri; }
- SVGLengthList* strokeDashArray() const { return stroke->dashArray.get(); }
+ SVGDashArray* strokeDashArray() const { return stroke->dashArray.get(); }
float strokeMiterLimit() const { return stroke->miterLimit; }
SVGLength* strokeWidth() const { return stroke->width.get(); }
const Length& strokeDashOffset() const { return stroke->dashOffset; }

Powered by Google App Engine
This is Rietveld 408576698