Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp

Issue 975733002: Use Length for the stroke-dasharray property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add test for style-change responsive-ness. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
diff --git a/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp b/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
index 4c3baa6250b0f3f95cc4897b77e8e49745996089..902e6ee632c66b1dff66176a7e4b0238585953a2 100644
--- a/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
+++ b/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
@@ -32,6 +32,7 @@
#include "core/animation/animatable/AnimatableValueTestHelper.h"
+#include "bindings/core/v8/ExceptionStatePlaceholder.h"
#include "core/layout/ClipPathOperation.h"
#include "core/layout/style/BasicShapes.h"
#include "core/svg/SVGLengthContext.h"
@@ -84,12 +85,12 @@ TEST_F(AnimationAnimatableValueTestHelperTest, PrintTo)
PrintToString(AnimatableShapeValue::create(ShapeValue::createShapeValue(BasicShapeCircle::create().get(), ContentBox).get())),
testing::StartsWith("AnimatableShapeValue@"));
- RefPtrWillBeRawPtr<SVGLengthList> l2 = SVGLengthList::create();
- l2->append(length1cm);
- l2->append(length2cm);
+ RefPtr<SVGDashArray> l2 = SVGDashArray::create();
+ l2->append(Length(1, blink::Fixed));
+ l2->append(Length(2, blink::Percent));
EXPECT_EQ(
- ::std::string("AnimatableStrokeDasharrayList(1cm, 2cm)"),
- PrintToString(AnimatableStrokeDasharrayList::create(l2)));
+ ::std::string("AnimatableStrokeDasharrayList(1+0%, 0+2%)"),
+ PrintToString(AnimatableStrokeDasharrayList::create(l2, 1)));
TransformOperations operations1;
operations1.operations().append(TranslateTransformOperation::create(Length(2, blink::Fixed), Length(0, blink::Fixed), TransformOperation::TranslateX));

Powered by Google App Engine
This is Rietveld 408576698