Use Length for the stroke-dasharray property in SVGLayoutStyle

Source/core/html/forms/InputType.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
  *
@@ skipping 14 matching lines @@
  *
  */
 
 #include "config.h"
 #include "core/html/forms/InputType.h"
 
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/InputTypeNames.h"
 #include "core/dom/AXObjectCache.h"
+#include "core/dom/ExceptionCode.h"

[pdr., 2015/03/05 21:35:59]

Nit: were these ExceptionCode.h's needed?

[fs, 2015/03/06 11:27:46]

Yes, there are various ExceptionState::throwDOMException calls here which
apparently got this included via SVGLengthList.h [1] in SVGLayoutStyleDefs.h
(ouch!?). But - like you - I was a bit surprised (amazed even) to see compile
errors pop up from that removal... (my favorite was the Worker.cpp one)

[1] which includes SVGListPropertyHelper.h which in turn includes
ExceptionCode.h

 #include "core/dom/NodeLayoutStyle.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/events/ScopedEventQueue.h"
 #include "core/fileapi/FileList.h"
 #include "core/frame/FrameHost.h"
 #include "core/html/FormDataList.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLShadowElement.h"
 #include "core/html/forms/ButtonInputType.h"
 #include "core/html/forms/CheckboxInputType.h"
@@ skipping 870 matching lines @@
 StepRange InputType::createStepRange(AnyStepHandling anyStepHandling, const Decimal& stepBaseDefault, const Decimal& minimumDefault, const Decimal& maximumDefault, const StepRange::StepDescription& stepDescription) const
 {
     const Decimal stepBase = findStepBase(stepBaseDefault);
     const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), minimumDefault);
     const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), maximumDefault);
     const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element().fastGetAttribute(stepAttr));
     return StepRange(stepBase, minimum, maximum, step, stepDescription);
 }
 
 } // namespace blink