Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 975683003: GCPlugin: Recognize templated registerWeakMembers() call. (Closed)

Created:
5 years, 9 months ago by Yuta Kitamura
Modified:
5 years, 9 months ago
CC:
chromium-reviews, zerny-chromium, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GCPlugin: Recognize templated registerWeakMembers() call. After the inlined trace transition, the callee part of registerWeakMembers() call can be of type CXXDependentScopeMemberExpr instead of UnresolvedMemberExpr. The plugin should be aware of this case. BUG=462511 R=kouhei@chromium.org CC=zerny@chromium.org, oilpan-reviews@chromium.org Committed: https://crrev.com/f0e68a4804b61add3a2bb0aed38ab1eb483c04a4 Cr-Commit-Position: refs/heads/master@{#319024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -21 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +26 lines, -20 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/heap/stubs.h View 1 chunk +4 lines, -1 line 0 comments Download
A tools/clang/blink_gc_plugin/tests/register_weak_members_template.h View 1 chunk +43 lines, -0 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/register_weak_members_template.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + tools/clang/blink_gc_plugin/tests/register_weak_members_template.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yuta Kitamura
5 years, 9 months ago (2015-03-04 06:52:26 UTC) #1
kouhei (in TOK)
lgtm
5 years, 9 months ago (2015-03-04 06:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975683003/1
5 years, 9 months ago (2015-03-04 06:55:53 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-04 07:11:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 07:17:40 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 07:18:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0e68a4804b61add3a2bb0aed38ab1eb483c04a4
Cr-Commit-Position: refs/heads/master@{#319024}

Powered by Google App Engine
This is Rietveld 408576698