Source/bindings/scripts/v8_interface.py - Issue 975673002: [bindings] v8_interface.py should support 'any' or 'object' in getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 975673002: [bindings] v8_interface.py should support 'any' or 'object' in getter/setter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index cf852f4efc5825e0fa5d5e3b287b00fa585b1bfa..6d086d992cccf4f59e8817949cc10ca6f8499772 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -1229,6 +1229,8 @@ def property_getter(getter, cpp_arguments):

return 'result.isNull()'

if idl_type.is_interface_type:

return '!result'

+ if idl_type.base_type in ('any', 'object'):

+ return 'result.isEmpty()'

return ''

idl_type = getter.idl_type

« no previous file with comments | « no previous file | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »