Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 975643003: Updates Debug mode edge count increment lengths for ARMv6. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 44159)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1222,10 +1222,22 @@
// Used by CodePatcher; so must be constant across all code in an isolate.
int32_t size = 3 * Instr::kInstrSize;
#if defined(DEBUG)
- size += 35 * Instr::kInstrSize;
+ if (TargetCPUFeatures::arm_version() == ARMv7) {
+ size += 35 * Instr::kInstrSize;
+ } else {
+ // To update this number for e.g. ARMv6, run a SIMARM build with
+ // --sim_use_armv6 on any Dart program.
+ size += 51 * Instr::kInstrSize;
+ }
#endif // DEBUG
if (VerifiedMemory::enabled()) {
- size += 20 * Instr::kInstrSize;
+ if (TargetCPUFeatures::arm_version() == ARMv7) {
+ size += 20 * Instr::kInstrSize;
+ } else {
+ // To update this number for e.g. ARMv6, run a SIMARM build with
+ // --sim_use_armv6 --verified_mem on any Dart program.
+ size += 28 * Instr::kInstrSize;
+ }
}
return size;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698