Issue 975643003: Updates Debug mode edge count increment lengths for ARMv6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 975643003: Updates Debug mode edge count increment lengths for ARMv6. (Closed)

Created:
5 years, 9 months ago by zra

Modified:
5 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Google), rmacnak, Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Updates Debug mode edge count increment lengths for ARMv6. Includes instructions for future updates. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44172

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_compiler_arm.cc	View		1 chunk	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

Hopefully this addition of instructions for updating the numbers will help keep things in sync.

5 years, 9 months ago (2015-03-03 06:24:52 UTC) #2

zra

Committed patchset #1 (id:1) manually as r44172 (presubmit successful).

5 years, 9 months ago (2015-03-03 15:23:21 UTC) #6

Vyacheslav Egorov (Google)

5 years, 9 months ago (2015-03-03 16:14:34 UTC) #8

Message was sent while issue was closed.

Given how fragile it is, should not we just record it in the isolate() once the
first instance of edge count increment is generated, instead of storing it as a
highly magical constant?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages