Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 975613002: QUIC - minor cleanup of the following field trials and used defaults for (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 12c846c9893953f14bce4ce048c7145e807d6d96..143ac484a29ffd7d52d3523b87a6446f0b9fcc23 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -135,9 +135,7 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options);
EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
EXPECT_FALSE(params.quic_disable_connection_pooling);
- EXPECT_EQ(0, params.quic_load_server_info_timeout_ms);
- EXPECT_EQ(0.0f, params.quic_load_server_info_timeout_srtt_multiplier);
- EXPECT_FALSE(params.quic_enable_truncated_connection_ids);
+ EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier);
EXPECT_FALSE(params.quic_enable_connection_racing);
EXPECT_FALSE(params.quic_enable_non_blocking_io);
EXPECT_FALSE(params.quic_disable_disk_cache);
@@ -294,15 +292,6 @@ TEST_F(IOThreadTest,
EXPECT_TRUE(params.quic_disable_connection_pooling);
}
-TEST_F(IOThreadTest, QuicLoadServerInfoTimeoutFromFieldTrialParams) {
- field_trial_group_ = "Enabled";
- field_trial_params_["load_server_info_timeout"] = "50";
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- EXPECT_EQ(50, params.quic_load_server_info_timeout_ms);
-}
-
TEST_F(IOThreadTest, QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) {
field_trial_group_ = "Enabled";
field_trial_params_["load_server_info_time_to_srtt"] = "0.5";
@@ -312,15 +301,6 @@ TEST_F(IOThreadTest, QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) {
EXPECT_EQ(0.5f, params.quic_load_server_info_timeout_srtt_multiplier);
}
-TEST_F(IOThreadTest, QuicEnableTruncatedConnectionIds) {
- field_trial_group_ = "Enabled";
- field_trial_params_["enable_truncated_connection_ids"] = "true";
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- EXPECT_TRUE(params.quic_enable_truncated_connection_ids);
-}
-
TEST_F(IOThreadTest, QuicEnableConnectionRacing) {
field_trial_group_ = "Enabled";
field_trial_params_["enable_connection_racing"] = "true";

Powered by Google App Engine
This is Rietveld 408576698