BrowserFontResource should not push opacity info to Blink

BrowserFontResource should not push opacity info to Blink

Blink's opacity & LCD logic is being removed - instead this is to be
handled by setting appropriate SkSurfaceProps onto the target canvas.

Unfortunately that's not directly applicable to
BrowserFontResource_Trusted::DrawTextAt/DrawTextToCanvas because the
API allows different opacity flags to be specified for different
calls directed to the same canvas.

We work around by disabling LCD text at the last stage, using a
temporary SkCanvas.

BUG=430617
R=reed@google.com,piman@chromium.org

Committed: https://crrev.com/34483e90726bc4537a746e2b49f3f47a2991a88f
Cr-Commit-Position: refs/heads/master@{#319645}

[f(malita), 2015-03-03 01:54:51]

Requires http://crrev.com/971133002

[reed1, 2015-03-03 15:04:42]

lgtm /w comment suggestion

https://codereview.chromium.org/975533004/diff/1/content/child/browser_font_r...
File content/child/browser_font_resource_trusted.cc (right):

https://codereview.chromium.org/975533004/diff/1/content/child/browser_font_r...
content/child/browser_font_resource_trusted.cc:419: destination->save();
save(); // will be balanced automatically by auto_restore above...

[f(malita), 2015-03-04 16:33:57]

fmalita@chromium.org changed reviewers:
+ mtklein@google.com

[f(malita), 2015-03-04 16:34:47]

Uploaded v2 which uses a temp canvas instead of a draw filter.

[reed1, 2015-03-04 20:19:58]

lgtm

[f(malita), 2015-03-05 14:53:36]

fmalita@chromium.org changed reviewers:
+ piman@chromium.org

[f(malita), 2015-03-05 14:54:11]

+piman for content.

The Blink API shim has landed and rolled - this is good to go.

[f(malita), 2015-03-06 14:58:58]

fmalita@chromium.org changed reviewers:
+ avi@chromium.org

[f(malita), 2015-03-09 14:42:50]

fmalita@chromium.org changed reviewers:
+ creis@chromium.org

[f(malita), 2015-03-09 14:43:17]

On 2015/03/05 14:54:11, f(malita) wrote:
> +piman for content.
> 
> The Blink API shim has landed and rolled - this is good to go.

Ping for content/ RS.

[Avi (use Gerrit), 2015-03-09 15:09:36]

lgtm

stampity stamp

[f(malita), 2015-03-09 15:10:09]

On 2015/03/09 15:09:36, Avi wrote:
> lgtm
> 
> stampity stamp

Thanks!

[f(malita), 2015-03-09 15:10:13]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-03-09 15:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975533004/20001

[commit-bot: I haz the power, 2015-03-09 16:01:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 16:02:30]

Patchset 2 (id:??) landed as
https://crrev.com/34483e90726bc4537a746e2b49f3f47a2991a88f
Cr-Commit-Position: refs/heads/master@{#319645}