Move didClearWindowObject to RenderFrame.

Move didClearWindowObject to RenderFrame.

BUG=361761
TEST=no visible change

Committed: https://crrev.com/570ee94ce954ad6ed1f04572797f87cc024d5a96
Cr-Commit-Position: refs/heads/master@{#318898}

[Avi (use Gerrit), 2015-03-02 21:39:16]

avi@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2015-03-02 23:06:37]

The only worry I have is the slight change in ordering of the calls in the new
version vs the old version.

https://codereview.chromium.org/975533002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/975533002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:2590:
FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
Shouldn't this be moved to be the first code in this method? It used to be the
first line in the RVI implementation of it.

[Avi (use Gerrit), 2015-03-03 17:17:27]

On 2015/03/02 23:06:37, nasko wrote:
> The only worry I have is the slight change in ordering of the calls in the new
> version vs the old version.

Yes, this was deliberate.

All of these actions that need to be taken (should) be independent of each
other. And the callbacks promise nothing either. So I intentionally arranged
things in a clean, consistent way inside of RenderFrame. This whole oopif thing
is a subtle source of bugs, so I would rather go all the way and write the code
that I want than try to keep things as unchanged as I can in fear that something
will break.

[nasko, 2015-03-03 17:23:37]

LGTM

[Avi (use Gerrit), 2015-03-03 17:26:42]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-03-03 17:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975533002/1

[commit-bot: I haz the power, 2015-03-03 17:30:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-03 17:31:11]

Patchset 1 (id:??) landed as
https://crrev.com/570ee94ce954ad6ed1f04572797f87cc024d5a96
Cr-Commit-Position: refs/heads/master@{#318898}