add double precision convex test

add double precision convex test

BUG=389050
Committed: https://skia.googlesource.com/skia/+/b421650e13faa2b77d29b018e78ab07ff693ca32

[caryclark, 2015-03-02 19:28:11]

caryclark@google.com changed reviewers:
+ reed@google.com, robertphillips@google.com

[reed1, 2015-03-02 19:38:03]

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp#newcode2182
src/core/SkPath.cpp:2182: if (!almost_equal(largest, largest + cross)) {
can we reorg this a little, and possible save any dup code? just wondering...

cross = ...;

if (almost_equal(...)) {
   // almost equal, so single-precision may not have been enough, so we
recompute using doubles.
    cross = doubletoscalar(new double code);
}

int sign = SkScalarSignAsInt(cross);
...

[caryclark, 2015-03-02 20:24:47]

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp#newcode2182
src/core/SkPath.cpp:2182: if (!almost_equal(largest, largest + cross)) {
Done, but not sure it's an improvement. (When I tried it as outlined above, I
ended up with cross = 0 in several places.)

[robertphillips, 2015-03-02 20:29:32]

Is this address the tiny path use case?

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp#newcode2223
src/core/SkPath.cpp:2223: SkASSERT(vec.fX || vec.fY);
this-> ?

[reed1, 2015-03-02 20:33:56]

ah, I didn't anticipate the extra checks/gotos. I'm fine to go back to the old
way if you like. Thanks for experimenting with it.

lgtm (either way)

[robertphillips, 2015-03-02 20:43:21]

lgtm. I prefer patch #1 though.

[caryclark, 2015-03-02 20:48:34]

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/975523002/diff/1/src/core/SkPath.cpp#newcode2223
src/core/SkPath.cpp:2223: SkASSERT(vec.fX || vec.fY);
On 2015/03/02 20:29:31, robertphillips wrote:
> this-> ?

Done.

[caryclark, 2015-03-02 20:48:38]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-03-02 20:48:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com, reed@google.com
Link to the patchset: https://codereview.chromium.org/975523002/#ps40001 (title:
"add this-> for directionChange")

[commit-bot: I haz the power, 2015-03-02 20:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/975523002/40001

[commit-bot: I haz the power, 2015-03-02 21:02:38]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b421650e13faa2b77d29b018e78ab07ff693ca32