Issue 975493002: Draw glyphs on Mac without font transform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 975493002: Draw glyphs on Mac without font transform. (Closed)

Created:
5 years, 9 months ago by bungeman-skia

Modified:
5 years, 9 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Draw glyphs on Mac without font transform. The transform on the font is increasingly going untested on Mac. As a result, only use the transform on the context when possible. This fixes color emoji on OSX10.2. Committed: https://skia.googlesource.com/skia/+/aae309111ba1803be5cfa2a81c273aa80ef3f825

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	src/ports/SkFontHost_mac.cpp	View	1 2	5 chunks	+16 lines, -13 lines	0 comments	Download

Total messages: 6 (2 generated)

bungeman-skia

This was tested not to affect Blink layout tests (at least not obviously) with https://codereview.chromium.org/970933002/ ...

5 years, 9 months ago (2015-03-02 21:25:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975493002/40001

5 years, 9 months ago (2015-03-02 21:37:11 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-02 21:43:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aae309111ba1803be5cfa2a81c273aa80ef3f825