Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 975473002: Set the ttcIndex on Mac onOpenStream. (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set the ttcIndex on Mac onOpenStream. Since on Mac onOpenStream always creates a new stream of a non-collection font, be sure the out ttcIndex is always set to 0. Committed: https://skia.googlesource.com/skia/+/b3310c222104d9234970c684d2b88b13038db7f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bungeman-skia
5 years, 9 months ago (2015-03-02 16:17:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975473002/1
5 years, 9 months ago (2015-03-02 16:37:12 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-02 16:37:12 UTC) #5
bungeman-skia
5 years, 9 months ago (2015-03-02 16:56:47 UTC) #7
reed1
lgtm
5 years, 9 months ago (2015-03-02 17:04:39 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:05:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b3310c222104d9234970c684d2b88b13038db7f0

Powered by Google App Engine
This is Rietveld 408576698