Parse comma-separated multiple values.

lib/src/parser.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library args.src.parser;
 
 import 'arg_parser.dart';
 import 'arg_results.dart';
 import 'option.dart';
 
@@ skipping 236 matching lines @@
 
   /// Called during parsing to validate the arguments.
   ///
   /// Throws a [FormatException] if [condition] is `false`.
   void validate(bool condition, String message) {
     if (!condition) throw new FormatException(message);
   }
 
   /// Validates and stores [value] as the value for [option].
   void setOption(Map results, Option option, value) {
-    // See if it's one of the allowed values.
-    if (option.allowed != null) {
-      validate(option.allowed.any((allow) => allow == value),
-          '"$value" is not an allowed value for option "${option.name}".');
+    if (!option.isMultiple) {
+      _validateAllowed(option, value);
+      results[option.name] = value;
+      return;
     }
 
-    if (option.isMultiple) {
-      var list = results.putIfAbsent(option.name, () => []);
-      list.add(value);
-    } else {
-      results[option.name] = value;
+    var list = results.putIfAbsent(option.name, () => []);
+    assert(value is String);

[Bob Nystrom, 2015/03/03 17:36:26]

Value can only be a string or bool, right? And flags don't allow multiple. Maybe
this would be clearer to have separate setOption() and setFlag() methods that
can be more statically typed. Thoughts?

[Sean Eagan, 2015/03/03 20:21:23]

They don't?  I know some people like to use `-vvv` to represent how verbose they
want the output to be.

[nweiz, 2015/03/03 20:22:18]

Done.

+    for (var subValue in value.split(",")) {

[Bob Nystrom, 2015/03/03 17:36:26]

"subValue" -> "subvalue". Or maybe just "element"?

[nweiz, 2015/03/03 20:22:18]

Done.

+      _validateAllowed(option, subValue);
+      list.add(subValue);
     }
   }
+
+  /// Validates that [value] is allowed as a value of [option].
+  void _validateAllowed(Option option, value) {

[Bob Nystrom, 2015/03/03 17:36:26]

Annotate value as String.

[nweiz, 2015/03/03 20:22:18]

Done.

+    if (option.allowed == null) return;
+
+    validate(option.allowed.any((allow) => allow == value),

[Bob Nystrom, 2015/03/03 17:36:26]

.contains(value)

?

[nweiz, 2015/03/03 20:22:18]

Done.

+        '"$value" is not an allowed value for option "${option.name}".');
+  }
 }