third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js - Issue 975453003: Update Google Input Tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js

Issue 975453003: Update Google Input Tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/google_input_tools/src/chrome/os/inputview/css.js ('k') | third_party/google_input_tools/src/chrome/os/inputview/elements/content/compactkey.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js

diff --git a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js

index 4bbe45aaeeef298021a3bd1dfdf48d60f481de4c..d3e1658450971f86c1fb1e7f816abbb6b581dfc7 100644

--- a/third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js

+++ b/third_party/google_input_tools/src/chrome/os/inputview/elements/content/candidateview.js

@@ -232,6 +232,7 @@ CandidateView.prototype.createDom = function() {

var dom = this.getDomHelper();

var elem = this.getElement();

+ goog.dom.classlist.add(elem, Css.CANDIDATE_VIEW);

for (var i = 0; i < this.toolbarButtons_.length; i++) {

var button = this.toolbarButtons_[i];

@@ -450,7 +451,6 @@ CandidateView.prototype.resize = function(width, height) {

CandidateView.prototype.switchToIcon = function(type, visible) {

for (var i = 0; i < this.iconButtons_.length; i++) {

- // Don't enable voice when focus in password box.

this.iconButtons_[i].setVisible(false);

}

@@ -459,6 +459,7 @@ CandidateView.prototype.switchToIcon = function(type, visible) {

this.iconButtons_[type].setVisible(true);

} else if (this.adapter_.isVoiceInputEnabled &&

this.adapter_.contextType != 'password') {

+ // Don't enable voice when focus in password box.

this.iconButtons_[type].setVisible(true);

}

} else if (this.adapter_.isVoiceInputEnabled &&