Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 975453002: DevTools: Remove pageAgent() call from DebuggerModel (Closed)

Created:
5 years, 9 months ago by sergeyv
Modified:
5 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Remove pageAgent() call from DebuggerModel BUG=462924 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191195

Patch Set 1 #

Patch Set 2 : Move OverlayController to main module #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -70 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
A Source/devtools/front_end/main/OverlayController.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +5 lines, -70 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
sergeyv
5 years, 9 months ago (2015-03-02 15:36:45 UTC) #2
dgozman
Please move it to "main" module. lgtm
5 years, 9 months ago (2015-03-02 15:50:52 UTC) #3
sergeyv
On 2015/03/02 15:50:52, dgozman wrote: > Please move it to "main" module. lgtm Done
5 years, 9 months ago (2015-03-02 16:11:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975453002/20001
5 years, 9 months ago (2015-03-02 16:12:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28057)
5 years, 9 months ago (2015-03-02 16:32:58 UTC) #9
pfeldman
lgtm
5 years, 9 months ago (2015-03-03 15:16:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975453002/20001
5 years, 9 months ago (2015-03-03 15:23:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=191195
5 years, 9 months ago (2015-03-03 15:25:49 UTC) #13
lushnikov
5 years, 9 months ago (2015-03-05 13:00:38 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/982783002/ by lushnikov@chromium.org.

The reason for reverting is: This breaks F8 shortcut. @see crbug.com/464342.

Powered by Google App Engine
This is Rietveld 408576698