runtime/vm/raw_object.h - Issue 975443003: Catch corrupted pointers earlier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object.h

Issue 975443003: Catch corrupted pointers earlier. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/raw_object.h

===================================================================

--- runtime/vm/raw_object.h (revision 44128)

+++ runtime/vm/raw_object.h (working copy)

@@ -284,7 +284,13 @@

class ClassIdTag :

public BitField<intptr_t, kClassIdTagPos, kClassIdTagSize> {}; // NOLINT

+ bool IsWellFormed() const {

+ uword value = reinterpret_cast<uword>(this);

+ return (value & kSmiTagMask) == 0 ||

+ Utils::IsAligned(value - kHeapObjectTag, kWordSize);

+ }

bool IsHeapObject() const {

+ ASSERT(IsWellFormed());

uword value = reinterpret_cast<uword>(this);

return (value & kSmiTagMask) == kHeapObjectTag;

}

@@ -305,6 +311,7 @@

// Like !IsHeapObject() || IsOldObject(), but compiles to a single branch.

bool IsSmiOrOldObject() const {

+ ASSERT(IsWellFormed());

COMPILE_ASSERT(kHeapObjectTag == 1);

COMPILE_ASSERT(kNewObjectAlignmentOffset == kWordSize);

static const uword kNewObjectBits =

« no previous file with comments | « runtime/vm/disassembler_x64.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »