Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/log.cc

Issue 97543002: Refactor BinaryOpIC to be able to use different stubs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/token.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1820 matching lines...) Expand 10 before | Expand all | Expand 10 after
1831 1831
1832 1832
1833 void Logger::LogCodeObject(Object* object) { 1833 void Logger::LogCodeObject(Object* object) {
1834 Code* code_object = Code::cast(object); 1834 Code* code_object = Code::cast(object);
1835 LogEventsAndTags tag = Logger::STUB_TAG; 1835 LogEventsAndTags tag = Logger::STUB_TAG;
1836 const char* description = "Unknown code from the snapshot"; 1836 const char* description = "Unknown code from the snapshot";
1837 switch (code_object->kind()) { 1837 switch (code_object->kind()) {
1838 case Code::FUNCTION: 1838 case Code::FUNCTION:
1839 case Code::OPTIMIZED_FUNCTION: 1839 case Code::OPTIMIZED_FUNCTION:
1840 return; // We log this later using LogCompiledFunctions. 1840 return; // We log this later using LogCompiledFunctions.
1841 case Code::BINARY_OP_IC: { 1841 case Code::BINARY_OP_IC:
Hannes Payer (out of office) 2013/12/02 11:39:00 you may wanna add the "// fall through" comment fo
1842 BinaryOpStub stub(code_object->extended_extra_ic_state());
1843 description = stub.GetName().Detach();
1844 tag = Logger::STUB_TAG;
1845 break;
1846 }
1847 case Code::COMPARE_IC: // fall through 1842 case Code::COMPARE_IC: // fall through
1848 case Code::COMPARE_NIL_IC: // fall through 1843 case Code::COMPARE_NIL_IC: // fall through
1849 case Code::TO_BOOLEAN_IC: // fall through 1844 case Code::TO_BOOLEAN_IC: // fall through
1850 case Code::STUB: 1845 case Code::STUB:
1851 description = 1846 description =
1852 CodeStub::MajorName(CodeStub::GetMajorKey(code_object), true); 1847 CodeStub::MajorName(CodeStub::GetMajorKey(code_object), true);
1853 if (description == NULL) 1848 if (description == NULL)
1854 description = "A stub from the snapshot"; 1849 description = "A stub from the snapshot";
1855 tag = Logger::STUB_TAG; 1850 tag = Logger::STUB_TAG;
1856 break; 1851 break;
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
2165 if (jit_logger_) { 2160 if (jit_logger_) {
2166 removeCodeEventListener(jit_logger_); 2161 removeCodeEventListener(jit_logger_);
2167 delete jit_logger_; 2162 delete jit_logger_;
2168 jit_logger_ = NULL; 2163 jit_logger_ = NULL;
2169 } 2164 }
2170 2165
2171 return log_->Close(); 2166 return log_->Close();
2172 } 2167 }
2173 2168
2174 } } // namespace v8::internal 2169 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/token.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698