Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 975363002: [x86] Fix InstructionSelector::SupportedMachineOperatorFlags(). (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Fix InstructionSelector::SupportedMachineOperatorFlags(). Word32 shifts are always safe on ia32 and x64, independent of whether SSE4.1 is available. R=dcarney@chromium.org Committed: https://crrev.com/ce785b5616d0f30832e7c199f1f82c3c6961b7e7 Cr-Commit-Position: refs/heads/master@{#26984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-04 13:16:45 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-04 13:17:21 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-04 13:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975363002/1
5 years, 9 months ago (2015-03-04 13:19:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 13:38:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:39:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce785b5616d0f30832e7c199f1f82c3c6961b7e7
Cr-Commit-Position: refs/heads/master@{#26984}

Powered by Google App Engine
This is Rietveld 408576698