Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 975323002: Revert of Fix BluetoothAdapterProfileChromeOS lifecycle management (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix BluetoothAdapterProfileChromeOS lifecycle management (patchset #7 id:120001 of https://codereview.chromium.org/935383003/) Reason for revert: Leaks detected. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/7185 ================================================================= ==22324==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 96 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0x901bd6 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:7 #2 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #3 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #4 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #5 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #6 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #7 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #8 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #9 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #10 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #11 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #12 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #13 0x80ad38 in Run base/callback.h:396:12 #14 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #15 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #16 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #17 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Indirect leak of 93 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0x7f35c92df739 in __gnu_cxx::new_allocator<char>::allocate(unsigned long, void const*) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/ext/new_allocator.h:92 #2 0x7f35c92ded2c in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:609 #3 0x7f35c92def04 in std::string::_Rep::_M_clone(std::allocator<char> const&, unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:631 #4 0x7f35c92dbc48 in std::string::reserve(unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:512 #5 0x9021d7 in operator+<char, std::char_traits<char>, std::allocator<char> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.tcc:702:7 #6 0x9021d7 in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:47 #7 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11 #8 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #9 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #10 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #11 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #12 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #13 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #14 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #15 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #16 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #17 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #18 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #19 0x80ad38 in Run base/callback.h:396:12 #20 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #21 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #22 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #23 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4d9b8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/device_unittests+0x4d9b8b) #1 0xd9c743 in chromeos::BluetoothProfileServiceProvider::Create(dbus::Bus*, dbus::ObjectPath const&, chromeos::BluetoothProfileServiceProvider::Delegate*) chromeos/dbus/bluetooth_profile_service_provider.cc:251:12 #2 0x90227f in chromeos::BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(device::BluetoothUUID const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:51:7 #3 0x901be8 in chromeos::BluetoothAdapterProfileChromeOS::Register(device::BluetoothUUID const&, chromeos::BluetoothProfileManagerClient::Options const&, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&, std::string const&)> const&) device/bluetooth/bluetooth_adapter_profile_chromeos.cc:28:11 #4 0x8f6c47 in chromeos::BluetoothAdapterChromeOS::UseProfile(device::BluetoothUUID const&, dbus::ObjectPath const&, chromeos::BluetoothProfileManagerClient::Options const&, chromeos::BluetoothProfileServiceProvider::Delegate*, base::Callback<void (chromeos::BluetoothAdapterProfileChromeOS*)> const&, base::Callback<void (std::string const&)> const&) device/bluetooth/bluetooth_adapter_chromeos.cc:982:5 #5 0x4ec8e2 in chromeos::BluetoothAdapterProfileChromeOSTest_SimultaneousRegisterFail_Test::TestBody() device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:359:3 #6 0x85da05 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2420:12 #7 0x85da05 in testing::Test::Run() testing/gtest/src/gtest.cc:2436 #8 0x85f619 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5 #9 0x86040a in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5 #10 0x874063 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4602:11 #11 0x8736b7 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12 #12 0x8736b7 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4220 #13 0x814bda in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10 #14 0x814bda in base::TestSuite::Run() base/test/test_suite.cc:230 #15 0x80ad38 in Run base/callback.h:396:12 #16 0x80ad38 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:181 #17 0x80a863 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:423:10 #18 0x7d25ac in main device/test/run_all_unittests.cc:14:10 #19 0x7f35c8c7276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Fix BluetoothAdapterProfileChromeOS lifecycle management > > Have BluetoothAdapterProfileChromeOS remove itself from adapters when it > is deleted via it's deconstructor, to avoid references being left behind > after deletion. > > BUG=457978 > > Committed: https://crrev.com/0cca591aaf6f6a0cbf46840faaead236dd8317a2 > Cr-Commit-Position: refs/heads/master@{#318925} TBR=keybuk@chromium.org,isherman@chromium.org,armansito@chromium.org,stgao@chromium.org,jamuraa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457978 Committed: https://crrev.com/e952a67a32b39829ba174d4095b1bb2c9d59a034 Cr-Commit-Position: refs/heads/master@{#319034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -319 lines) Patch
M chromeos/dbus/fake_bluetooth_profile_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_bluetooth_profile_manager_client.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 3 chunks +8 lines, -18 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 4 chunks +26 lines, -72 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_profile_chromeos.h View 3 chunks +7 lines, -11 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_profile_chromeos.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc View 8 chunks +21 lines, -105 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.h View 1 chunk +4 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.cc View 5 chunks +18 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos_unittest.cc View 2 chunks +1 line, -69 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
Created Revert of Fix BluetoothAdapterProfileChromeOS lifecycle management
5 years, 9 months ago (2015-03-04 08:49:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/975323002/1
5 years, 9 months ago (2015-03-04 08:49:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 08:50:26 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 08:51:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e952a67a32b39829ba174d4095b1bb2c9d59a034
Cr-Commit-Position: refs/heads/master@{#319034}

Powered by Google App Engine
This is Rietveld 408576698