Start caching the theme color in web_contents

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 2751 matching lines @@
 
   if (delegate_)
     return delegate_->CanOverscrollContent();
 
   return false;
 }
 
 void WebContentsImpl::OnThemeColorChanged(SkColor theme_color) {
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
                     DidChangeThemeColor(theme_color));
+  RenderWidgetHostView* rwhv = GetRenderWidgetHostView();
+  if (rwhv)
+    rwhv->SetThemeColor(theme_color);

[no sievers, 2015/03/04 23:00:46]

Why don't you just cache it in here?
Esp. since the getter API is also in WebContents.

[Yusuf, 2015/03/04 23:26:29]

Then wouldn't we have to refresh it explicitly when we navigate to a new URL? We
get a new rwhv in that case, but web contents wont change, right?

[no sievers, 2015/03/04 23:37:42]

Wait, isn't the bug then that we don't get a notification here although the
theme color changed?

[Yusuf, 2015/03/04 23:38:56]

We only get notified if there is a color, but don't get anything if there isn't.

 }
 
 void WebContentsImpl::OnDidLoadResourceFromMemoryCache(
     const GURL& url,
     const std::string& security_info,
     const std::string& http_method,
     const std::string& mime_type,
     ResourceType resource_type) {
 
   // Send out a notification that we loaded a resource from our memory cache.
@@ skipping 1753 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content