refactoring Android Webview JNI_OnLoad interface

base/android/library_loader/library_loader_hooks.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/library_loader/library_loader_hooks.h"
 
 #include "base/android/command_line_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/library_loader/library_load_from_apk_status_codes.h"
 #include "base/at_exit.h"
@@ skipping 105 matching lines @@
 }
 
 void LibraryLoaderExitHook() {
   if (g_at_exit_manager) {
     delete g_at_exit_manager;
     g_at_exit_manager = NULL;
   }
 }
 
 bool RegisterLibraryLoaderEntryHook(JNIEnv* env) {
+  // TODO(michaelbai): Remove this after refactoring all dependents.
+  InitAtExitManager();
   // We need the AtExitManager to be created at the very beginning.
-  g_at_exit_manager = new base::AtExitManager();
-
+  DCHECK(g_at_exit_manager);
   return RegisterNativesImpl(env);
 }
 
 void SetVersionNumber(const char* version_number) {
   g_library_version_number = strdup(version_number);
 }
 
 jstring GetVersionNumber(JNIEnv* env, jobject jcaller) {
   return ConvertUTF8ToJavaString(env, g_library_version_number).Release();
 }
 
 LibraryProcessType GetLibraryProcessType(JNIEnv* env) {
   return static_cast<LibraryProcessType>(
       Java_LibraryLoader_getLibraryProcessType(env));
 }
 
+void InitAtExitManager() {

[Torne, 2015/03/11 18:08:29]

Why do we need to InitAtExitManager in this way at all? Can't it be done during
the regular init for base? I assume something that's happening during
registerjni requires it; what is that? SHould it be there?

[michaelbai, 2015/03/11 18:29:10]

As I said in my previous comment, I am refactoring other components which
initialized AtExitManager by itself, once it is done, we no longer need to call
InitAtExitManager in android_webview, even better, it might be done before
landing this patch 

+  g_at_exit_manager = new base::AtExitManager();
+}
+
 }  // namespace android
 }  // namespace base