Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 975233002: Merge 191215 "Revert 187103 "Fix ignored taps in contextual sear..." (Closed)

Created:
5 years, 9 months ago by kerz_chromium
Modified:
5 years, 9 months ago
Reviewers:
Miyoung Shin(g)
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Merge 191215 "Revert 187103 "Fix ignored taps in contextual sear..." > Revert 187103 "Fix ignored taps in contextual search on Android" > Revert 186550 "Fix the problem to keep the selection when clicking..." > Revert 185410 "Make sure that selection is cleared after tapping." > Revert 181959 "Fix to keep the selection of the text field in input..." > > Reason for revert: > Cursor doesn't enter into Password field text-box on first tap > on Handsets & Tablets of Android. > First I revert the origin patch related to the selection, then > I will check this issue. > > Revert 187103 : > > Fix ignored taps in contextual search on Android > > > > We should keep the selection when tapping-press and clear > > the selection state after tapping release. > > Focus, mouse-down and mouse-press events are triggered on > > tapping. The problem is that the selection state was > > initialized after handling mouse-press event. > > We should initialize it after handling mousedown event like > > the formal mouse event. > > > > BUG=440086 > > R=rbyers@chromium.org,donnd@chromium.org,yosin@chromium.org > > TEST=fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html > > Revert 186550 : > > Fix the problem to keep the selection when clicking the substring out of ran > > > > The problem is that it's not consistent to keep the selection when clicking > > substiring in/out of range. We need the additional condition missing > > from http://crrev.com/507533002 > > > > BUG=32865, 438102 > > R=yosin@chromium.org > > R=rbyers@chromium.org > > TEST=fast/forms/setrangetext-out-of-range.html > > Revert 185410 : > > Make sure that selection is cleared after tapping. > > > > The problem is that Selection is not getting cleared > > after tapping of gesture. This was affected by > > https://codereview.chromium.org/507533002, > > because initialization for m_selectionInitiationState was > > skipped in case of gesture. > > This patch makes m_selectionInitiationState be initialized > > after dispatching mousedown event for gesture tapping. > > > > BUG=429967 > > R=rbyers@chromium.org > > TEST=LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range > > Revert 181959: > > Fix to keep the selection of the text field in input element after setSelect > > > > The problem is that the selection is cleared when handling mouse release. > > The selection should be kept if the selection is set by setSelectionRange du > > > > BUG=32865 > > R=yosin@chromium.org > > R=rbyers@chromium.org > >TEST=LayoutTests/fast/forms/setrangetext-within-events.html > > BUG=457147 > R=rbyers@chromium.org, yosin@chromium.org, donnd@chromium.org > > Review URL: https://codereview.chromium.org/965203003 TBR=myid.o.shin@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -242 lines) Patch
D LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-out-of-range.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-out-of-range-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-within-events.html View 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/forms/setrangetext-within-events-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 5 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kerz_chromium
5 years, 9 months ago (2015-03-04 00:33:03 UTC) #1
kerz_chromium
5 years, 9 months ago (2015-03-04 00:33:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r191218.

Powered by Google App Engine
This is Rietveld 408576698