Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 9752002: This patch is an effort to simplify cascading jumps to return label in such case:

Created:
8 years, 9 months ago by kewpie.w.zp
Modified:
6 years, 4 months ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

This patch is an effort to simplify cascading jumps to return label in such case: return (?(?(?:):(?:)):(?(?:):(?:(?:)))); In this return statement, expression is Conditional (could be recursive) but just branches to accumulator values. In tridition, each Conditional expression would yeild a jump to 'done' internal label, then cascading-jumps occur from inner-most one to out-most one. I think it should be faster to jump to 'return_label_' by single step instead of cascading jumps if following requirements are met: 1) Such Conditional expression is not encapculated as part of binary operation 2) Such Conditional expression is not encapculated as part of function arguments Both tools/presubmit.py and tools/test.py got passed. Please kindly help review and comment.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -3 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/full-codegen.h View 6 chunks +41 lines, -1 line 0 comments Download
M src/full-codegen.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kewpie.w.zp
7 years, 11 months ago (2013-01-08 09:59:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698